Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart cannot use a database if patroni.enabled=false #131

Closed
pbolduc opened this issue Feb 27, 2023 · 2 comments
Closed

Helm Chart cannot use a database if patroni.enabled=false #131

pbolduc opened this issue Feb 27, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@pbolduc
Copy link
Contributor

pbolduc commented Feb 27, 2023

Describe the bug

When using the Helm chart, if I set patroni.enabled=false, the chart cannot be deployed due to an error. I want to use a different HA database deployed separately from the COMS helm chart. We have a number of databases in our system, I do not want duplicate Patroni clusters which requires more resources and monitoring.

To Reproduce

Steps to reproduce the behavior:

  1. Run

helm upgrade coms ./common-object-management-service-0.0.8.tgz --install --values coms-values.yaml --set patroni.enabled=false

  1. See error,

Error: template: common-object-management-service/templates/deploymentconfig.yaml:43:27: executing "common-object-management-service/templates/deploymentconfig.yaml" at <include "patroni.fullname" .Subcharts.patroni>: error calling include: template: no template "patroni.fullname" associated with template "gotpl"

Expected behavior

I would be expected if not enabling patroni in the chart, I can reference an existing postgres database with appropriate credentials.

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@jujaga
Copy link
Member

jujaga commented Mar 16, 2023

Thanks for this report. We have plans to support non-Patroni dependency managed databases via the dbSecretOverride value in values.yaml and have added it into our backlog.

@jujaga jujaga added bug Something isn't working enhancement New feature or request labels Mar 16, 2023
jujaga added a commit that referenced this issue Apr 12, 2023
@jujaga
Copy link
Member

jujaga commented Apr 13, 2023

Addressed in #158

@jujaga jujaga closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants