Feature/secret override #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Configured Secrets to use scoped releases
…object-management-service into feature/secretOverride
cberg-aot
requested review from
jujaga,
kamorel,
TimCsaky and
bcgv123
as code owners
bcgv123
approved these changes
Apr 12, 2023
jujaga
suggested changes
Apr 12, 2023
There was a problem hiding this comment.
StringData is not a good design pattern. I do see the current misalignment concern with the overrides not being base64 encoded, but this should be done via a proper string operation and pipe instead of depending on StringData. As it is implemented right now, this would work for the override, but this would double encrypt the default generated password values instead, leading to unintended results.
I'll be taking a look at this and doing parallel adjustments to the helm chart to compensate for the issue.
jujaga
added a commit
that referenced
this pull request
Apr 12, 2023
Renames variables in secrets template to be more consistent with purpose Signed-off-by: Jeremy Ho <[email protected]>
4 tasks
|
Superceded by #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored Secret objects to use stringData instead of Data as field. This prevents base64 error when trying to pull data into the secret that may not be base64 (such as usernames).
Types of changes
Refactor w/ encryption side effects (should make Secrets work as intended).
Checklist
Further comments
Tested with manual helm install, and NOT piping secrets to | base64.
This wasn't a tested workflow during the original PR (was feeding test data to base64, overlooking the usual flow of just placing stringData into the secret)