-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public constructor to internal classes which are instantiated via IoC #19
Add public constructor to internal classes which are instantiated via IoC #19
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.0.0 #19 +/- ##
=================================================
+ Coverage 45.09% 45.27% +0.17%
=================================================
Files 100 100
Lines 1785 1831 +46
Branches 117 117
=================================================
+ Hits 805 829 +24
- Misses 954 976 +22
Partials 26 26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also add a test case using Castle.Windsor?
Definitely, yes - I've create #22 for this. |
Please rebase on |
7eeecb5
to
cebf232
Compare
cebf232
to
46e59fc
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment to the empty constructors why they are required? Otherwise someone will quite likely remove them in the future. Otherwise LGTM
46e59fc
to
4503d6c
Compare
Done that. |
…al with public constructor), where needed (#17)
4503d6c
to
04227d6
Compare
Fixes #17