Skip to content

Commit

Permalink
Make constructor of internal classes public (or public classes intern…
Browse files Browse the repository at this point in the history
…al with public constructor), where needed.
  • Loading branch information
Marco Bertschi committed Nov 15, 2019
1 parent d0a6376 commit 46e59fc
Show file tree
Hide file tree
Showing 30 changed files with 170 additions and 12 deletions.
5 changes: 1 addition & 4 deletions src/BBT.StructureTools.Tests/TestTools/TestIoContainer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ public static class TestIoContainer
/// </summary>
public static IKernel Initialize()
{
var settings = new NinjectSettings
{
InjectNonPublic = true,
};
var settings = new NinjectSettings();

var kernel = new StandardKernel(settings);

Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Compare/CompareHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@
/// <inheritdoc/>
internal class CompareHelper : ICompareHelper
{
/// <summary>
/// Initializes a new instance of the <see cref="CompareHelper" /> class.
/// </summary>
public CompareHelper()
{
}

/// <inheritdoc/>
public void DoComparePostProcessing<T, TIntention>(
T candidate1Nullable,
Expand Down
2 changes: 1 addition & 1 deletion src/BBT.StructureTools/Compare/Comparer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal class Comparer<T, TIntention> : IComparer<T, TIntention>
/// <summary>
/// Initializes a new instance of the <see cref="Comparer{TModelToCompare,TCompareIntention}" /> class.
/// </summary>
internal Comparer(
public Comparer(
ICompareRegistrations<T, TIntention> compareRegistrations,
IEqualityComparerHelperRegistrationFactory factory,
ICompareHelper compareHelper)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ internal class EqualityComparerHelperOperations<TModel> : IEqualityComparerHelpe
/// <summary>
/// Initializes a new instance of the <see cref="EqualityComparerHelperOperations{TModel}"/> class.
/// </summary>
internal EqualityComparerHelperOperations(IEnumerable<IEqualityComparerHelperStrategy<TModel>> registeredStrategies)
public EqualityComparerHelperOperations(IEnumerable<IEqualityComparerHelperStrategy<TModel>> registeredStrategies)
{
registeredStrategies.NotNull(nameof(registeredStrategies));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using BBT.StructureTools.Extension;

/// <inheritdoc/>
public class EqualityComparerHelperRegistration<T> : IEqualityComparerHelperRegistration<T>
internal class EqualityComparerHelperRegistration<T> : IEqualityComparerHelperRegistration<T>
where T : class
{
private readonly ICollection<IEqualityComparerHelperStrategy<T>> registeredStrategies;
Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Compare/TypeComparer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
/// </summary>
internal sealed class TypeComparer : IComparer<Type>
{
/// <summary>
/// Initializes a new instance of the <see cref="TypeComparer"/> class.
/// </summary>
public TypeComparer()
{
}

/// <inheritdoc/>
public int Compare(Type x, Type y)
{
Expand Down
2 changes: 1 addition & 1 deletion src/BBT.StructureTools/Convert/ConvertEngine.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace BBT.StructureTools.Convert
{
/// <inheritdoc/>
public class ConvertEngine<TSource, TTarget> : IConvertEngine<TSource, TTarget>
internal class ConvertEngine<TSource, TTarget> : IConvertEngine<TSource, TTarget>
where TSource : class
where TTarget : class
{
Expand Down
9 changes: 8 additions & 1 deletion src/BBT.StructureTools/Convert/ConvertHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@
using BBT.StructureTools.Extension;

/// <inheritdoc/>
public class ConvertHelper : IConvertHelper
internal class ConvertHelper : IConvertHelper
{
/// <summary>
/// Initializes a new instance of the <see cref="ConvertHelper"/> class.
/// </summary>
public ConvertHelper()
{
}

/// <inheritdoc/>
public void DoConvertPreProcessing<TSourceClass, TTargetClass>(
TSourceClass source,
Expand Down
4 changes: 2 additions & 2 deletions src/BBT.StructureTools/Convert/Converter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using BBT.StructureTools.Extension;

/// <inheritdoc/>
public class Converter<TSource, TTarget, TConvertIntention> : IConvert<TSource, TTarget, TConvertIntention>
internal class Converter<TSource, TTarget, TConvertIntention> : IConvert<TSource, TTarget, TConvertIntention>
where TSource : class
where TTarget : class
where TConvertIntention : IBaseConvertIntention
Expand All @@ -15,7 +15,7 @@ public class Converter<TSource, TTarget, TConvertIntention> : IConvert<TSource,
/// <summary>
/// Initializes a new instance of the <see cref="Converter{TSource, TTarget, TConvertIntention}" /> class.
/// </summary>
internal Converter(
public Converter(
IConvertRegistrations<TSource, TTarget, TConvertIntention> convertRegistrations,
IConvertEngine<TSource, TTarget> convertEngine,
IConvertHelper convertHelper)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
internal class ConvertStrategyProvider<TSource, TTarget, TIntention> : IConvertStrategyProvider<TSource, TTarget, TIntention>
where TIntention : IBaseConvertIntention
{
/// <summary>
/// Initializes a new instance of the <see cref="ConvertStrategyProvider{TSource, TTarget, TIntention}"/> class.
/// </summary>
public ConvertStrategyProvider()
{
}

/// <inheritdoc/>
public ISourceConvertStrategy<TSource, TTarget, TIntention> GetConvertStrategyFromSource(TSource source)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ internal class OperationCopySource<TSource, TTarget>
{
private Expression<Func<TTarget, TSource>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopySource{TSource, TTarget}"/> class.
/// </summary>
public OperationCopySource()
{
}

/// <inheritdoc/>
public void Initialize(Expression<Func<TTarget, TSource>> targetExpression)
{
Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Convert/Strategy/OperationCopyValue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ internal class OperationCopyValue<TSource, TTarget, TValue>
private Func<TSource, TValue> sourceFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValue{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValue()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TValue> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ internal class OperationCopyValueIfSourceNotDefault<TSource, TTarget, TValue>
private Func<TSource, TValue> sourceFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValueIfSourceNotDefault{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValueIfSourceNotDefault()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TValue> aSourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ internal class OperationCopyValueIfTargetIsDefault<TSource, TTarget, TValue>
private Func<TSource, TValue> sourceFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValueIfTargetIsDefault{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValueIfTargetIsDefault()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TValue> aSourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ internal class OperationCopyValueWithLookUp<TSource, TTarget, TValue>
private Func<TSource, TValue> sourceLookupFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValueWithLookUp{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValueWithLookUp()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TValue> aSourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ internal class OperationCopyValueWithSourceFilter<TSource, TTarget, TValue>
private Func<TSource, TTarget, TValue> sourceFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValueWithSourceFilter{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValueWithSourceFilter()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TTarget, TValue> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ internal class OperationCopyValueWithUpperLimit<TSource, TTarget, TValue>
private Func<TSource, TValue> sourceUpperLimitFunc;
private Expression<Func<TTarget, TValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCopyValueWithUpperLimit{TSource, TTarget, TValue}"/> class.
/// </summary>
public OperationCopyValueWithUpperLimit()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TValue> aSourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ internal class OperationCreateFromSourceWithReverseRelation<TSource, TTarget, TT
private ICreateConvertHelper<TSource, TTargetValue, TConcreteTargetValue, TTarget, TConvertIntention> createConvertHelper;
private Expression<Func<TTarget, TTargetValue>> targetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCreateFromSourceWithReverseRelation{TSource, TTarget, TTargetValue, TConcreteTargetValue, TConvertIntention}"/> class.
/// </summary>
public OperationCreateFromSourceWithReverseRelation()
{
}

/// <inheritdoc/>
public void Initialize(
Expression<Func<TTarget, TTargetValue>> targetExpression,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ internal class OperationCreateToOne<TSource, TTarget, TSourceValue, TTargetValue
private Expression<Func<TTarget, TTargetValue>> targetExpression;
private ICreateConvertHelper<TSourceValue, TTargetValue, TConcreteTargetValue, TConvertIntention> createConvertHelper;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCreateToOne{TSource, TTarget, TSourceValue, TTargetValue, TConcreteTargetValue, TConvertIntention}"/> class.
/// </summary>
public OperationCreateToOne()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TSourceValue> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ internal class OperationCreateToOneWithReverseRelation<TSource, TTarget, TSource
private Expression<Func<TTarget, TTargetValue>> targetExpression;
private ICreateConvertHelper<TSourceValue, TTargetValue, TConcreteTargetValue, TTarget, TConvertIntention> createConvertHelper;

/// <summary>
/// Initializes a new instance of the <see cref="OperationCreateToOneWithReverseRelation{TSource, TTarget, TSourceValue, TTargetValue, TConcreteTargetValue, TConvertIntention}"/> class.
/// </summary>
public OperationCreateToOneWithReverseRelation()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TSource, TSourceValue> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ internal class ConvertValueRegistration<TSource, TTarget> : IConvertValueRegistr
{
private readonly IValueConvertMapping<TSource, TTarget> valueConvertMapping = new ValueConvertMapping<TSource, TTarget>();

/// <summary>
/// Initializes a new instance of the <see cref="ConvertValueRegistration{TSource, TTarget}"/> class.
/// </summary>
public ConvertValueRegistration()
{
}

/// <inheritdoc/>
public IConvertValueRegistration<TSource, TTarget> Register(TSource sourceValue, TTarget targetValue)
{
Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Convert/Value/ValueConvertMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ internal class ValueConvertMapping<TSource, TTarget> : IValueConvertMapping<TSou
private readonly HashSet<TSource> mapToException = new HashSet<TSource>();
private Func<TTarget> nullCaseFunc;

/// <summary>
/// Initializes a new instance of the <see cref="ValueConvertMapping{TSource, TTarget}"/> class.
/// </summary>
public ValueConvertMapping()
{
}

/// <inheritdoc/>
public void AddException(TSource sourceValue)
{
Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Copy/Helper/CopyHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
/// <inheritdoc/>
internal class CopyHelper : ICopyHelper
{
/// <summary>
/// Initializes a new instance of the <see cref="CopyHelper"/> class.
/// </summary>
public CopyHelper()
{
}

/// <inheritdoc/>
public void DoCopyPostProcessing<TClassToCopy>(
TClassToCopy source,
Expand Down
7 changes: 7 additions & 0 deletions src/BBT.StructureTools/Copy/Helper/CopyHelperFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ internal class CopyHelperFactory<TTarget, TConcreteTarget>
where TTarget : class
where TConcreteTarget : class, TTarget, new()
{
/// <summary>
/// Initializes a new instance of the <see cref="CopyHelperFactory{TTarget, TConcreteTarget}"/> class.
/// </summary>
public CopyHelperFactory()
{
}

/// <inheritdoc/>
public ICreateCopyHelper<TTarget, TConcreteTarget, TReverseRelation> GetCopyHelper<TReverseRelation>(
Expression<Func<TTarget, TReverseRelation>> reverseRelationFunc)
Expand Down
2 changes: 1 addition & 1 deletion src/BBT.StructureTools/Copy/Helper/CopyHelperOperations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal class CopyHelperOperations<T> : ICopyOperation<T>
/// <summary>
/// Initializes a new instance of the <see cref="CopyHelperOperations{T}"/> class.
/// </summary>
internal CopyHelperOperations(IEnumerable<ICopyOperation<T>> registeredStrategies)
public CopyHelperOperations(IEnumerable<ICopyOperation<T>> registeredStrategies)
{
registeredStrategies.NotNull(nameof(registeredStrategies));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
/// </summary>
internal class CopyHelperRegistrationFactory : ICopyHelperRegistrationFactory
{
/// <summary>
/// Initializes a new instance of the <see cref="CopyHelperRegistrationFactory"/> class.
/// </summary>
public CopyHelperRegistrationFactory()
{
}

/// <summary>
/// Creates an instance of CopyHelperRegistration.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ internal class CopyOperationCreateFromFactory<T, TValue, TAttributeValueFactory>

private TAttributeValueFactory attributeValueFactory;

/// <summary>
/// Initializes a new instance of the <see cref="CopyOperationCreateFromFactory{T, TValue, TAttributeValueFactory}"/> class.
/// </summary>
public CopyOperationCreateFromFactory()
{
}

/// <inheritdoc/>
public void Copy(T source, T target, ICopyCallContext copyCallContext)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ internal class CopyOperationCreateToManyWithReverseRelation<TParent, TChild, TCo
private Func<TParent, IEnumerable<TChild>> sourceFunc;
private Maybe<Expression<Func<TParent, ICollection<TChild>>>> maybeTargetExpression;

/// <summary>
/// Initializes a new instance of the <see cref="CopyOperationCreateToManyWithReverseRelation{TParent, TChild, TConcreteChild}"/> class.
/// </summary>
public CopyOperationCreateToManyWithReverseRelation()
{
}

/// <inheritdoc/>
public void Initialize(
Func<TParent, IEnumerable<TChild>> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ internal class CopyOperationCreateToOneWithReverseRelation<T, TChild, TConcreteC

private ICreateCopyHelper<TChild, TConcreteChild, T> createCopyHelper;

/// <summary>
/// Initializes a new instance of the <see cref="CopyOperationCreateToOneWithReverseRelation{T, TChild, TConcreteChild}"/> class.
/// </summary>
public CopyOperationCreateToOneWithReverseRelation()
{
}

/// <inheritdoc/>
public void Initialize(
Func<T, TChild> sourceFunc,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ internal class CopyOperationCrossReferenceProcessing<T, TCrossReferencedModel, T
{
private Expression<Func<TReferencingModel, TCrossReferencedModel>> referencingPropertyExpression;

/// <summary>
/// Initializes a new instance of the <see cref="CopyOperationCrossReferenceProcessing{T, TCrossReferencedModel, TReferencingModel}"/> class.
/// </summary>
public CopyOperationCrossReferenceProcessing()
{
}

/// <inheritdoc/>
public void Initialize(
Expression<Func<TReferencingModel, TCrossReferencedModel>> referencingProperty)
Expand Down

0 comments on commit 46e59fc

Please sign in to comment.