Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public constructor to internal classes which are instantiated via IoC #17

Closed
marco-bertschi opened this issue Nov 12, 2019 · 1 comment
Closed

Add public constructor to internal classes which are instantiated via IoC #17

marco-bertschi opened this issue Nov 12, 2019 · 1 comment
Assignees
@marco-bertschi
Labels
Bug Something isn't working
Milestone
1.0.0

Comments

@marco-bertschi
Copy link
Contributor

Some IoC containers (such as Castle Windsor) don't support instantiation of internal objects with an internal C'tor.

  • Add public constructor where neccessary
  • Adjust NInject for testing to enforce a public constructor
@marco-bertschi marco-bertschi added the Bug Something isn't working label Nov 12, 2019
@marco-bertschi marco-bertschi self-assigned this Nov 12, 2019
@pascalberger pascalberger added this to the 1.0.0 milestone Nov 12, 2019
@marco-bertschi marco-bertschi mentioned this issue Nov 12, 2019
Merged
marco-bertschi pushed a commit that referenced this issue Nov 16, 2019
Make constructor of internal classes public (or public classes intern…
4503d6c 
…al with public constructor), where needed (#17)
marco-bertschi pushed a commit that referenced this issue Nov 16, 2019
Make constructor of internal classes public (or public classes intern…
04227d6 
…al with public constructor), where needed (#17)
marco-bertschi added a commit that referenced this issue Nov 16, 2019
@marco-bertschi
Make constructor of internal classes public (or public classes intern…
574dcbb 
…al with public constructor), where needed (#19)

See issue #17
@marco-bertschi
Copy link
Contributor Author

Fixed with #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-bertschi marco-bertschi

Labels
Bug Something isn't working
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@pascalberger @marco-bertschi