Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Topology Cache Group Servers table to use AG-Grid #7849

Merged
merged 7 commits into from
Nov 12, 2023

Conversation

ntheanh201
Copy link
Contributor

Closes: #6501

This updates the "Cache Groups" Traffic Portal page to use AG-Grid instead of JQuery datatables.


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Make sure all the TP tests pass, make sure the new table looks okay.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@ntheanh201
Copy link
Contributor Author

@ocket8888 @mitchell852

In the TP tests it showed that Failed: Wait timed out after 2023ms. Do you guys know what exactly is this error?

image

@ocket8888 ocket8888 self-assigned this Nov 1, 2023
@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Nov 1, 2023
@ocket8888
Copy link
Contributor

In the TP tests it showed that Failed: Wait timed out after 2023ms. Do you guys know what exactly is this error?

Not without looking at the tests within traffic_portal/test/integration, but my guess is some selector that's looking for the old JQuery table needs to be updated.

@ntheanh201
Copy link
Contributor Author

In the TP tests it showed that Failed: Wait timed out after 2023ms. Do you guys know what exactly is this error?

Not without looking at the tests within traffic_portal/test/integration, but my guess is some selector that's looking for the old JQuery table needs to be updated.

@ocket8888 It has some differences between the response message after deletion and the test data, I fixed it. Can you please take a look?

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #7849 (10d752b) into master (cb74c5b) will increase coverage by 2.71%.
Report is 9 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7849      +/-   ##
============================================
+ Coverage     29.20%   31.91%   +2.71%     
  Complexity       98       98              
============================================
  Files           533      719     +186     
  Lines         71066    82788   +11722     
  Branches         90      970     +880     
============================================
+ Hits          20753    26425    +5672     
- Misses        48423    54201    +5778     
- Partials       1890     2162     +272     
Flag Coverage Δ
golib_unit 53.86% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.80% <ø> (-0.12%) ⬇️
traffic_monitor_unit 26.44% <ø> (?)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 21.68% <0.00%> (+<0.01%) ⬆️
traffic_portal_v2 74.35% <ø> (?)
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 29.24% <0.00%> (+3.49%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c_ops/traffic_ops_golang/cachegroup/cachegroups.go 14.79% <0.00%> (+0.01%) ⬆️

... and 187 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ocket8888 ocket8888 merged commit 5f6b1c6 into apache:master Nov 12, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Topology Cache Group Servers table to use AG-Grid instead of jQuery "dataTables"
2 participants