Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Topology Cache Group Servers table to use AG-Grid #7849

Merged
merged 7 commits into from
Nov 12, 2023
Merged

Update Topology Cache Group Servers table to use AG-Grid #7849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
463ea85
Update Topology Cache Group Servers table to use AG-Grid
ntheanh201 Oct 25, 2023
639b3e6
reformat code + add case undefined update cache group
ntheanh201 Oct 25, 2023
2368be5
remove toggle test
ntheanh201 Oct 28, 2023
cc2dcef
add open topology menu
ntheanh201 Nov 2, 2023
787d29f
fix return wrong value when update cache groups
ntheanh201 Nov 2, 2023
3d7e166
update delete cache group success message for testable
ntheanh201 Nov 2, 2023
10d752b
fix delete cg validation message
ntheanh201 Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
### Changed
- [#7614](https://github.com/apache/trafficcontrol/pull/7614) *Traffic Ops* The database upgrade process no longer overwrites changes users may have made to the initially seeded data.
- [#7832](https://github.com/apache/trafficcontrol/pull/7832) *t3c* Removed perl dependency
- Updated the CacheGroups Traffic Portal page to use a more performant AG-Grid-based table.

## [8.0.0] - 2023-09-20
### Added
Expand Down
3 changes: 1 addition & 2 deletions traffic_ops/traffic_ops_golang/cachegroup/cachegroups.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,8 +1405,7 @@
return
}

alertMessage := fmt.Sprintf("%s was deleted.", ID)
alerts := tc.CreateAlerts(tc.SuccessLevel, alertMessage)
alerts := tc.CreateAlerts(tc.SuccessLevel, "cache group was deleted.")

Check warning on line 1408 in traffic_ops/traffic_ops_golang/cachegroup/cachegroups.go

View check run for this annotation

Codecov / codecov/patch

traffic_ops/traffic_ops_golang/cachegroup/cachegroups.go#L1408 

Added line #L1408 was not covered by tests
api.WriteAlerts(w, r, http.StatusOK, alerts)
return
}
Expand Down
Loading
Loading