-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1027] Store failed annotations error report #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - just one small change, but this is looking great!
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! I'm going to pre-approve!
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 39 New issues |
Note that this PR introduces a new variable |
Purpose: This PR is intended to allow the concatenation and storage to Synapse of the failed annotations per center. This is currently a draft PR - there's some points of discussion needed in some areas.
Changes:
Old functions:
New functions:
These functions are created primarily for the concatenation and storage to synapse of the annotation reports. We also have a check function that just makes sure our narrow maf failed annotations count match the error report rows.
Testing:
Depends on #544