Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1027] Store failed annotations error report #545

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Jan 9, 2024

Purpose: This PR is intended to allow the concatenation and storage to Synapse of the failed annotations per center. This is currently a draft PR - there's some points of discussion needed in some areas.

Changes:
Old functions:

New functions:
These functions are created primarily for the concatenation and storage to synapse of the annotation reports. We also have a check function that just makes sure our narrow maf failed annotations count match the error report rows.

Testing:

  • Unit and integration tests added to, to account for the new and revised functions above
  • Ran on docker image built on this branch
  • Ran processing on just mutation data and files show up here in the Errors folders for each center: https://www.synapse.org/#!Synapse:syn11601248/tables/

Depends on #544

tests/conftest.py Show resolved Hide resolved
genie/process_mutation.py Outdated Show resolved Hide resolved
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - just one small change, but this is looking great!

genie/process_mutation.py Outdated Show resolved Hide resolved
genie/process_mutation.py Show resolved Hide resolved
genie/process_mutation.py Outdated Show resolved Hide resolved
genie/process_mutation.py Show resolved Hide resolved
Copy link

dpulls bot commented Jan 11, 2024

🎉 All dependencies have been resolved !

Base automatically changed from gen-1026-output-error to develop January 11, 2024 19:10
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! I'm going to pre-approve!

@rxu17 rxu17 marked this pull request as ready for review January 13, 2024 00:36
@rxu17 rxu17 requested a review from a team as a code owner January 13, 2024 00:36
@rxu17 rxu17 requested a review from thomasyu888 January 13, 2024 00:37
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

39 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rxu17
Copy link
Contributor Author

rxu17 commented Jan 24, 2024

Note that this PR introduces a new variable genomic_location_explanation to the full maf file during mutation processing that leads an issue with the store_maf_files function in genie/database_to_staging.py that will be resolved with #548. See that PR for more details.

@rxu17 rxu17 merged commit 4f9be49 into develop Jan 24, 2024
8 checks passed
@rxu17 rxu17 deleted the gen-1027-store-error-report branch January 24, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants