-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1028] Generate failed annotations report dashboard #546
Conversation
One outstanding question is the historical reason behind not running the dashboard code on the test pipeline? Currently it defaults to running on production: Genie/bin/database_to_staging.py Lines 289 to 294 in 446de5c
|
There's not a good reason other than tech debt. If you notice in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦖 LGTM! This is great - have you had a chance to check out quarto at all? I recently created nice looking dashboards like this using purely Python code. It's a game changer.
Note: Not saying we should convert to quarto in this PR. ha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate the tests added here.
Somehow I missed the notifications to the comments in this PR. I have not, this is my first time touching dashboard code here haha but I remember you used it for the hefty data guide PR. Quarto looks great, I am down to just convert to it (plus easier to integrate in tests when it's python and moving away from R dependencies is a plus). |
@rxu17 Lets create a separate ticket to export to quarto, but this is PR is good to go |
🎉 All dependencies have been resolved ! |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Purpose: This is a draft PR. This PR will add a section to our dashboard that showcases the number of failed annotations per center and also let sites know where to find their failed annotations report
Testing:
Depends on #545