-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1076] Exclude genomic_location_explanation from release #548
Conversation
Also feels like we need to also enforce an expected schema for the full maf file during the end of process_mutation given that we have this new variable |
🎉 All dependencies have been resolved ! |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 9 New issues |
It was decided to just use a list of release variables for the full maf file to subset out the non-release variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM! Thanks for doing this! I just had one comment, but going to pre-approve!
Purpose: This is a draft PR. This PR is only allowing in certain release variables (excluding out the
genomic_location_explanation
andAnnotation_Status
variables for example) for the full maf csv.Changes:
create_missing_columns
inprocess_functions.py
Decided with this implementation on excluding variables because we have older full maf files that may have been processed 1-N releases ago, and doesn't contain new columns and features we added to maf processing since then. Because we append old full maf files and more recently processed maf files, we want to make sure they conform to a specific expected schema so we set the expected columns they should have and if they don't have the column, it's created and filled with missing values.Testing:
Depends on #545