Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View HelpWindow: internal links in help modify browser window.location #24

Open
bwbohl opened this issue Aug 1, 2013 · 9 comments
Open

Comments

@bwbohl
Copy link
Member

bwbohl commented Aug 1, 2013

Navigating the help with internal links alters the address in the browsers address line. to e.g. http://localhost:8080/exist/#helpWindow-1059view.window.source.SourceView_viewMenu

@ghost ghost assigned roewenstrunk Aug 1, 2013
@bwbohl bwbohl closed this as completed Aug 1, 2013
@bwbohl bwbohl reopened this Aug 1, 2013
@bwbohl
Copy link
Member Author

bwbohl commented Jul 16, 2015

could you please help locating the error?

@bwbohl bwbohl assigned roewenstrunk and unassigned roewenstrunk Jul 16, 2015
@bwbohl bwbohl added the Status: needs review Issues that might be resolved in current develop label Feb 9, 2022
@bwbohl bwbohl added this to the help milestone Oct 5, 2022
nikobeer added a commit that referenced this issue Feb 19, 2024
@daniel-jettka daniel-jettka removed this from the help milestone Jun 3, 2024
@krHERO
Copy link
Member

krHERO commented Jul 1, 2024

@bwbohl is this still an issue?

@bwbohl
Copy link
Member Author

bwbohl commented Jul 2, 2024

at least in https://edition.freischuetz-digital.de/
in https://klarinettenquintett.weber-gesamtausgabe.de/ which probably is the latest deployment the help button is actually missing completely

@bwbohl bwbohl changed the title internal links in help modify browser window.location View HelpWindow: internal links in help modify browser window.location Jul 2, 2024
@krHERO krHERO moved this to In Progress in Edirom Development Jul 3, 2024
@krHERO krHERO added this to the 1.0.0 milestone Jul 3, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Sep 10, 2024

blocked by #209

@bwbohl
Copy link
Member Author

bwbohl commented Nov 8, 2024

fix links as described in #387 or test with the updated implementation of text transformations in dev, first.

@roewenstrunk
Copy link
Member

Hi @riedde , for what reason do you introduced the <base target="_blank"/> in

<base target="_blank"/>)

This prevents the internal links in text files (so the help also) to work. I know, that we need a better mechanism which does not alter the browser address line, but for the moment…

@riedde
Copy link
Contributor

riedde commented Dec 4, 2024

@roewenstrunk I didn't really introduced this, I took it from the old index.html, I guess. Have you testes if the edirom starts without this element?

@krHERO krHERO added Type: feature request and removed Type: bug report Status: needs review Issues that might be resolved in current develop labels Dec 11, 2024
@krHERO
Copy link
Member

krHERO commented Dec 11, 2024

Hi @riedde , for what reason do you introduced the <base target="_blank"/> in

<base target="_blank"/>)

This prevents the internal links in text files (so the help also) to work. I know, that we need a better mechanism which does not alter the browser address line, but for the moment…

this issue was mistakenly used to start a discussion about broken internal links. for this reason a new issue #498 taking care about internal links that are not working was created. this issue #24 stays open as a feature request and the bug-label is deleted.

krHERO added a commit to krHERO/Edirom-Online that referenced this issue Dec 16, 2024
this commit adds a language variable for measure.

closes Edirom#24
@krHERO krHERO closed this as completed in b52634e Dec 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edirom Development Dec 17, 2024
@krHERO krHERO reopened this Dec 17, 2024
@peterstadler peterstadler moved this from Done to Backlog in Edirom Development Dec 17, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Dec 18, 2024

This apparently is due to the default _self that’s being applied to anchor elements. I’m currently working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants