Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "base target blank" in index.xql #508

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

roewenstrunk
Copy link
Member

Description, Context and related Issue

The change solves the internal link problem #498
There should be a more elegant solution in a later release like discussed in #24

Refs #498

How Has This Been Tested?

Tested with EditionExample data on my machine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Overview

@krHERO krHERO added this to the 1.0.0 milestone Dec 18, 2024
Copy link
Contributor

@daniel-jettka daniel-jettka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works...

  • links in the help window are opened in the same window
  • same for footnote links in "Zum vorliegenden Band" in Klarinettenquintett

Hint:

  • also links to external sites in other windows open sites in same tab, e.g.
    image

@bwbohl bwbohl added the Type: bugfix A pull request providing a bugfix label Dec 18, 2024
@bwbohl bwbohl linked an issue Dec 18, 2024 that may be closed by this pull request
@krHERO krHERO merged commit 925ed78 into develop Dec 19, 2024
5 checks passed
@krHERO krHERO deleted the fix-internal-links-workaround branch December 19, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bugfix A pull request providing a bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] help: internal links are not working
4 participants