Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] help: internal links are not working #498

Closed
krHERO opened this issue Dec 11, 2024 · 2 comments · Fixed by #508
Closed

[BUG] help: internal links are not working #498

krHERO opened this issue Dec 11, 2024 · 2 comments · Fixed by #508

Comments

@krHERO
Copy link
Member

krHERO commented Dec 11, 2024

Describe the problem
in the help the internal links are not working. they should jump to the referenced topics of the help text, but they open a new browser tab.

To Reproduce
with a click on an internal link a new browser window with a new edirom-online opens.

Expected behavior
they should jump to the referenced topics of the help text

Edirom information

Environment information

@daniel-jettka
Copy link
Contributor

If the links with @href="#..." had a @target="_self" then this might fix the problem.

At least that works when I add this in the console. However, I do not know where this would have to be added in xql or xslt stylesheets...

image

@krHERO
Copy link
Member Author

krHERO commented Dec 18, 2024

we agreed at the communty meeting 2024-12-18 to re-introduce the needed line for v1.0.0 @roewenstrunk and to work on this topic again at a later release.

@bwbohl bwbohl moved this from Backlog to In Progress in Edirom Development Dec 18, 2024
@bwbohl bwbohl linked a pull request Dec 18, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edirom Development Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants