-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): discover SBUS trainer availability #4266
Conversation
cbb8318
to
68745a8
Compare
Notes to myself: |
59193a3
to
e31f94a
Compare
a64bb3c
to
a67bd79
Compare
a67bd79
to
eeee419
Compare
171efef
to
13cb5fc
Compare
tested ok on NV14 with ELRS nano RX on 3.3.1 configured to output SBUS |
Frsky Horus X10S Express (ACCESS), using a Frsky FWTM module (same as #4324). EdgeTX 2.10 rc4 When selecting Master-SBUS under Model/Trainer, module now powers up and allows binding to buddy box using ACCESS or ACCST. But, no SBUS control signals passed back from module to act as Sources on the Master. This does work using a Taranis X9d (OTX 2.3.15) as master with this module. |
x9d expects SBUS trainer input on the HB pin, whilst most other radios expect it on the S.Port pin. Does the module work on the x10s under otx? |
No, it did not - according to Frsky and Mike Blandford, the pin configuration was changed on the first X10's, killing the sbus input capability. BUT on the X10S-E (my version) it WAS restored, but OTX never reimplemented. Prior discussions about this in RC Groups and in GitHub indicated that Edge would be adding the sbus detection to allow this in all radios that had the capability in 2.10. Seems like it isn't quite fully functional....(or I've been misled by Frsky and Mike Blandford). |
use any of your receivers, set them to SBUS output and wire it to the JR bay GND/VCC/S.Port and try Master/SBUS again |
Now that is interesting....using an old x8r connected as you noted works just fine. Guess I can do that instead of the fancy module. Wonder why it works in the Taranis, and not in the X10S? Thank you! I did try connecting the SB sig to the HB pin (pin #2) in the x8r test, but no joy. But it did work once the SB sig went to the S.Port pin (Pin #5). |
The x9d is one of the few radios that have a functional HB input and expects SBUS on the HB pin. As the module was designed to work with those radios it outputs SBUS on the HB pin. The X10s expects SBUSin on the SPort pin. I'm sure the module will work if you feed the modules HB pin to the X10s SPort pin. The use case for Master/SBUS is to allow connecting receivers via SBUSout of the receivers. Depending on the radio you need to feed SBUS to the right pin. This is mainly the SPort pin, only fir Taranis radios it's the HB pin. If in doubt try SPort first and if that doesn't work try the HB pin. |
Thank you for the extended explanation! And thanks to all that worked on this to get it up and running on Edge! |
This PR allows for discovering on runtime if a serial port is available to allow for SBUS trainer on the external module bay.
Summary of changes:
This PR adds SBUS/CPPM trainer capability to to the X10 Express and CPPM trainer to the X10 / X12S. Radios that have been modded with a UART on PPM/HB (aka. "External ACCESS mod") will profit from this as well, even if configured dynamically by assigning AUX1 to the external module.