Trainer Mode Master/Serial turns Off when reading models and settings from radio to Companion

[clarke-john]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

When I ‘Read Models and Settings from Radio’ to Companion the setting for the ‘Trainer Mode’ changes from ‘Master/Serial’ to ‘Off’.
‘Write Models and Settings to Radio’ from Companion works fine and the Trainer Mode setting is not lost in this transfer.
I noticed this bug in February (version 2.9.4) but didn't report it.

Expected Behavior

I would expect the Trainer Mode setting on the radio to be transferred to Companion.

Steps To Reproduce

On a model in the radio, set 'Trainer Mode’ to ‘Master/Serial’.
Open Companion and connect radio to PC.
In Companion click on ‘Read Models and Settings from Radio’.
Open the model.
Check the setting for the ‘Trainer Mode’ and note that it has changed from ‘Master/Serial’ to ‘Off’.

Version

2.10.5

Transmitter

FrSky X10 / X10S (ACCST)

Operating System (OS)

Windows

OS Version

W11

Anything else?

No response

[pfeerick]

I am able to reproduce this on TX16S also.

• Set AUX1 to "SBUS Trainer", to enable the "Master/Serial" trainer option
• Configure Trainer Mode to be Master/Serial on handset
• Companion reads as OFF, although "Master/Serial" is in the list of options

Also, "Master/SBUS Module" is missing as a trainer option in Companion, and results in a blank (not OFF) field.

[elecpower]

Thanks @pfeerick more work lol

[pfeerick]

Yeah, I know... that todo list never gets any shorter! 😆

[pfeerick]

Hm... #4266 is at least part of the reason for this, as it dynamically checks if the radio has hardware capabilities (which allowed a few more radios to have SBUS/CPPM option and also checks if it is in use by something else...

[clarke-john]

Thank you all very much for fixing this bug. I look forward to it in the next release. I also appreciate all the work and dedication the devs put into giving us this superb firmware for our radios. Best wishes John From: Peter Feerick ***@***.***> Sent: 29 November 2024 00:54 To: EdgeTX/edgetx ***@***.***> Cc: clarke-john ***@***.***>; Author ***@***.***> Subject: Re: [EdgeTX/edgetx] Trainer Mode Master/Serial turns Off when reading models and settings from radio to Companion (Issue #5676) Closed #5676 <#5676> as completed via #5684 <#5684> . — Reply to this email directly, view it on GitHub <#5676 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANPDETP3SG6OSGAQ44HVOYL2C63MHAVCNFSM6AAAAABSAN7LN2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ3TAMBYHAYDANY> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ANPDETITQLL2I6IBSU3ETZ32C63MHA5CNFSM6AAAAABSAN7LN2WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAHGQWZ5DQ.gif> Message ID: ***@***.*** ***@***.***> >