Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external module power for SBUS trainer #4326

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: external module power for SBUS trainer #4326

merged 1 commit into from
Nov 15, 2023

Conversation

raphaelcoeffic
Copy link
Member

Please note that this PR is explicitely targeted at 2.9, as the main should be fixed with the more generic PR (see #4266)

Fixes #4324

When no external module USART is present

Fixes #4324
@3djc
Copy link
Collaborator

3djc commented Nov 15, 2023

Tested ok on X7

@pfeerick
Copy link
Member

Well, ouch... there's more than one init_trainer_module_sbus()/stop_trainer_module_sbus()? There's 'ye problem!

Also good on X9D+ (CPPM was fine post #4167, SBUS is good now also).

@pfeerick pfeerick added the bug 🪲 Something isn't working label Nov 15, 2023
@pfeerick pfeerick added this to the 2.9.x milestone Nov 15, 2023
@pfeerick pfeerick merged commit 4ea6a42 into 2.9 Nov 15, 2023
34 checks passed
@pfeerick pfeerick deleted the 2.9-fix-4324 branch November 15, 2023 22:20
@pfeerick pfeerick linked an issue Nov 16, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No power when selecting Trainer CPPM in 2.9.2
3 participants