Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No power when selecting Trainer CPPM in 2.9.2 #4324

Closed
1 task done
sande005 opened this issue Nov 14, 2023 · 4 comments · Fixed by #4326
Closed
1 task done

No power when selecting Trainer CPPM in 2.9.2 #4324

sande005 opened this issue Nov 14, 2023 · 4 comments · Fixed by #4326
Labels
bug 🪲 Something isn't working

Comments

@sande005
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Selecting Trainer Master/CPPM Module does not supply power to the module in use as implemented in #4167

Expected Behavior

Although tested module uses SBUS and not CPPM, one would expect the trainer option to supply power, even if SBUS is not currently supported.
Selecting any External Module will power the module, although trainer options then limited to Master/Jack or Slave/Jack.

Steps To Reproduce

Select None for external module.
Select Master/CPPM in Trainer section.
Restart radio, and note the module bind led's do not light, as they do when external module is enabled.

Version

Other (Please specify below)

Transmitter

FrSky X10 Express / X10S Express (ACCESS)

Operating System (OS)

Windows

OS Version

11

Anything else?

Tested with above TX running version 2.9.2 and a Frsky FWTM wireless trainer module.
Used x10-access-v2.9.2.bin to update TX.

@sande005 sande005 added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Nov 14, 2023
@Groove70
Copy link

I have supply power for the module in MASTER/CPPM, but not for MASTER/SBUS. Transmitter QX7 ACCST 2.9.2

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Nov 14, 2023

@sande005 is that possible that it only works when you set up it, but not after a restart?

At least on a TX16S it seems to work properly even after a restart.

@sande005
Copy link
Author

So odd...it honestly was not working over the last two days. Tried all the combinations many times on different days, with restarts everytime I changed something. No new models, no reflashing.
But, just now, before responding to this thread, gave it one last try (trainer/cppm selected, external module off) ...and the embedded RX is getting power and binding to the slave TX. Of course no control, but to be expected with needing sbus instead of CPPM. It continues to work, after 10 power cycles.
Module not dismounted/remounted during all this, but perhaps I have to look closer at pin and socket contacts.

Just for curiosity, I'll update my Taranis Plus from OTX to Edge, in light of Groove70's comment, to see what happens, and respond back here.

@Groove70
Copy link

What I can reproduce regardless of restarting/rebooting the device X7 with 2.9.2:
TRAINER/CPPM Power on the module pins (didn't work in 2.9.1).
TRAINER/SBUS No Power on module pins.
I always crosscheck with External Module ON where I have power on the pins (external receiver led).

raphaelcoeffic added a commit that referenced this issue Nov 15, 2023
When no external module USART is present

Fixes #4324
@pfeerick pfeerick removed the triage Bug report awaiting review / sorting label Nov 16, 2023
@pfeerick pfeerick linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants