Add event and device tracking to answers (M2-8482) #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egodoy-metalab @Phillipe-Bojorquez This PR adds new fields to /answers endpoint, we may need to update tests |
rcmerlo
requested review from
ChaconC,
farmerpaul,
mbanting and
sultanofcardio
and removed request for
ChaconC and
farmerpaul
|
➡️ Preview environment failed to be destroyed |
|
❌ E2E tests failed |
sultanofcardio
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Nice work getting this out so quickly @rcmerlo. Unfortunately I forgot to call attention to the format of the event_history_id, so we'll need a few changes
...ture/database/migrations/versions/2025_02_24_16_10-add_event_history_id_and_device_id_to_.py
Outdated
Show resolved
Hide resolved
...ase/migrations_arbitrary/versions/2025_02_24_16_10-add_event_history_id_and_device_id_to_.py
Outdated
Show resolved
Hide resolved
farmerpaul
requested changes
Feb 25, 2025
rcmerlo
force-pushed
the
M2-8482-BE-Update-answers-endpoint-to-accept-schedule-version-and-device-ID
branch
from
2473108 to
a1f763f
Compare
There was a problem hiding this comment.
Thanks for addressing my previous comments @rcmerlo. I think we're very close, just a few other things I noticed
farmerpaul
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Tests are passing with the web app PR, nice work! Just one last request.
rcmerlo
force-pushed
the
M2-8482-BE-Update-answers-endpoint-to-accept-schedule-version-and-device-ID
branch
from
82736c6 to
81d2964
Compare
sultanofcardio
requested changes
Feb 26, 2025
farmerpaul
approved these changes
Feb 26, 2025
rcmerlo
force-pushed
the
M2-8482-BE-Update-answers-endpoint-to-accept-schedule-version-and-device-ID
branch
from
d97b6ed to
e62a913
Compare
- Introduced `event_history_id` and `device_id` fields in the answer schema. - Updated services to handle new fields, including validation for event existence. - Added tests for creating answers with these new fields. - Implemented database migrations to support the new columns.
- Bumped version of `boto3` to 1.37.* - Updated `nh3` to use a wildcard version - Upgraded `ddtrace` to 2.21.* - Added new package `izulu` with version 0.5.4
- Added `device_id` as a header parameter in the API. - Integrated `UserDeviceService` to validate `device_id`. - Updated answer creation logic to include `device_id`. - Removed `device_id` from the domain model. - Enhanced tests for device ID scenarios, including invalid cases. - Fixed a bug in schedule history retrieval by correcting variable name. Enhance device and event validation logic - Updated device retrieval to check both device_id and user_id. - Enhanced event history lookup with activity or flow ID validation. - Modified test data for consistency with new logic. - Added SQLAlchemy case statement for conditional queries. Refactor device and event history checks - Updated `aio-pika` to version 9.5.5 in dependencies. - Simplified device validation by removing user ID check from the query. - Streamlined event history validation logic, removing complex query conditions. - Removed unused imports and redundant methods for cleaner codebase. - Adjusted database migration down_revision for consistency.
- Replaced `UserDeviceService` with `UserDeviceEventsHistoryCRUD` for device validation. - Added a new method `get_device` in `UserDeviceEventsHistoryCRUD`. - Updated logic to validate devices based on event history. - Modified test cases to align with the new device validation approach. - Removed unused imports and code related to the old device service.
- Added a new migration script to merge two branches. - Defined revision identifiers for Alembic. - Included empty upgrade and downgrade functions.
rcmerlo
force-pushed
the
M2-8482-BE-Update-answers-endpoint-to-accept-schedule-version-and-device-ID
branch
from
e62a913 to
f5b47b6
Compare
rcmerlo
deleted the
M2-8482-BE-Update-answers-endpoint-to-accept-schedule-version-and-device-ID
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
event_history_idanddevice_idfields in the answer schema.🔗 Jira Ticket M2-8482