Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event history id to answer submissions (M2-8481) #944

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

ChaconC
Copy link
Contributor

@ChaconC ChaconC commented Feb 26, 2025

📝 Description

Important

For the answer submission to be accepted by the BE, it requires running it with this branch checked out: ChildMindInstitute/mindlogger-backend-refactor#1754

🔗 Jira Ticket M2-8481

Adds eventHistoryId to new submissions, making sure to use the existing queue service.

🪤 Peer Testing

  • Create a new Applet/Activity
  • Submit the activity using the mobile app
  • Validate eventHistoryId is included in the payload
    • You can review the encryptedData payload in AnswersUploadService.uploadAnswers or by ensuring event_history_id is saved in the new answer directly in the database.

@ChaconC ChaconC marked this pull request as ready for review February 26, 2025 18:34
@ChaconC ChaconC changed the title Feat/m2 8481 answer device feat: add event history id to answer submissions (M2-8481) Feb 26, 2025
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and tests passing. 😄

@ChaconC ChaconC merged commit f46f56f into dev Feb 27, 2025
5 checks passed
@ChaconC ChaconC deleted the feat/M2-8481-answer-device-id branch February 27, 2025 14:33
@sultanofcardio
Copy link
Contributor

@ChaconC ChildMindInstitute/mindlogger-backend-refactor#1754 should be merged first to prevent breaking answer submission in the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants