Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Submit eventHistoryId in answer data (M2-8480) #587

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

farmerpaul
Copy link
Contributor

@farmerpaul farmerpaul commented Feb 25, 2025

📝 Description

Important

For the answer submission to be accepted by the BE, it requires running it with this branch checked out: ChildMindInstitute/mindlogger-backend-refactor#1754

🔗 Jira Ticket M2-8480

This change adds the eventHistoryId property to answer submissions.

🪤 Peer Testing

  1. Create an applet with an activity.
  2. Log into the Web App.
  3. Open DevTools Network tab.
  4. Submit an assessment and observe the payload of the POST /answers request:
    Expected outcome: The JSON object should contain the property eventHistoryId with a value in this format: [event ID]_[version].

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-587.d15zn9do8xbzga.amplifyapp.com

@farmerpaul farmerpaul marked this pull request as ready for review February 25, 2025 17:14
Copy link
Contributor

@sultanofcardio sultanofcardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good with one suggested change

Copy link
Contributor

@ChaconC ChaconC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated with updated BE, working now!

@sultanofcardio
Copy link
Contributor

@farmerpaul it shouldn't be long now, but be sure that ChildMindInstitute/mindlogger-backend-refactor#1754 is merged before this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants