Creating dedicated memory pools for data and control traffic #78588
+124
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
krish2718
reviewed
Sep 17, 2024
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
rado17
force-pushed
the
dedicated_mem_pools
branch
from
b162373 to
23d6eea
Compare
krish2718
reviewed
Nov 28, 2024
rado17
force-pushed
the
dedicated_mem_pools
branch
from
23d6eea to
073e311
Compare
sachinthegreen
previously approved these changes
Jan 2, 2025
jukkar
reviewed
Jan 2, 2025
modules/nrf_wifi/os/shim.c
Outdated
|
|
||
| struct zep_shim_intr_priv *intr_priv; | ||
|
|
||
| static void *zep_shim_mem_alloc(size_t size) | ||
| { | ||
| size_t size_aligned = ROUND_UP(size, 4); | ||
| size = (size + 4) & 0xfffffffc; |
There was a problem hiding this comment.
Why not use the ROUND_UP macro here and below?
rado17
force-pushed
the
dedicated_mem_pools
branch
2 times, most recently
from
ad272f6 to
0201f96
Compare
Create dedicated memory pools for Wi-Fi management and data operations (defaults: 20KB for management and 130KB for data). Remove the `HEAP_MEM_POOL_ADD_SIZE_NRF70` hint since we are creating separate heaps for driver and not allocating from system heap. Signed-off-by: Ravi Dondaputi <[email protected]>
Pull changes for creating separate memory pools for control traffic and data traffic. Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
force-pushed
the
dedicated_mem_pools
branch
from
0201f96 to
8dae35d
Compare
krish2718
reviewed
Jan 16, 2025
| @@ -535,6 +529,16 @@ config NRF70_RSSI_STALE_TIMEOUT_MS | |||
|
|
|||
| if NETWORKING | |||
| # Finetune defaults for certain system components used by the driver | |||
|
|
|||
| config NRF_WIFI_CTRL_HEAP_SIZE | |||
| int "Dedicated memory pool for control path" | |||
There was a problem hiding this comment.
Suggested change
| int "Dedicated memory pool for control path" | |
| int "Dedicated memory pool for control plane" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated memory pools for Wi-Fi management and
data operations