Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: Create dedicated mem pool for Wi-Fi driver #15169

Closed
wants to merge 2 commits into from

Conversation

rado17
Copy link
Contributor

@rado17 rado17 commented May 3, 2024

Create dedicated memory pools for Wi-Fi management and
data operations (defaults: 20KB for management and 60KB for data).

Reduce the heap memory pool size since the Wi-Fi driver will
be allocating memory from a dedicated pool.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 3, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 3, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@cfcb4b0 (main) nrfconnect/sdk-nrfxlib#1319 nrfconnect/sdk-nrfxlib#1319/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@rado17 rado17 changed the title Dedicated mem pool drivers: wifi: Create dedicated mem pool for Wi-Fi driver May 3, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

drivers/wifi/nrf700x/src/shim.c Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/src/shim.c Outdated Show resolved Hide resolved
drivers/wifi/nrf700x/src/shim.c Show resolved Hide resolved
drivers/wifi/nrf700x/src/shim.c Outdated Show resolved Hide resolved
samples/wifi/shell/overlay-zperf.conf Outdated Show resolved Hide resolved
rado17 added 2 commits July 25, 2024 13:49
Pull in changes for dedicated memory heaps.

Signed-off-by: Ravi Dondaputi <[email protected]>
Create dedicated memory pools for Wi-Fi management and
data operations (defaults: 20KB for management and 60KB for data).

Reduce the heap memory pool size since the Wi-Fi driver will
be allocating memory from a dedicated pool.

Signed-off-by: Ravi Dondaputi <[email protected]>
@rado17 rado17 force-pushed the dedicated_mem_pool branch from 11ebac8 to 1b83a6a Compare July 25, 2024 08:20
@rado17 rado17 requested a review from krish2718 July 25, 2024 08:33
@@ -596,6 +596,14 @@ if NETWORKING
config HEAP_MEM_POOL_SIZE
default 153000

config NRF_WIFI_CONFIG_HEAP_MEM_POOL_SIZE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config NRF_WIFI_CONFIG_HEAP_MEM_POOL_SIZE
config NRF_WIFI_CTRL_HEAP_SIZE

@@ -596,6 +596,14 @@ if NETWORKING
config HEAP_MEM_POOL_SIZE
default 153000

config NRF_WIFI_CONFIG_HEAP_MEM_POOL_SIZE
int "Dedicated memory pool for configuration"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int "Dedicated memory pool for configuration"
int "Dedicated memory pool for control path"

int "Dedicated memory pool for configuration"
default 20480

config NRF_WIFI_DATA_HEAP_MEM_POOL_SIZE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config NRF_WIFI_DATA_HEAP_MEM_POOL_SIZE
config NRF_WIFI_DATA_HEAP_SIZE


static void zep_shim_mem_free(void *buf)
{
if (buf) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, ISO C semantics are followed in Zephyr.

@@ -12,7 +12,7 @@ CONFIG_NET_PKT_RX_COUNT=30
CONFIG_NET_PKT_TX_COUNT=29
CONFIG_NET_BUF_RX_COUNT=30
CONFIG_NET_BUF_TX_COUNT=58
CONFIG_HEAP_MEM_POOL_SIZE=230000
#CONFIG_HEAP_MEM_POOL_SIZE=140000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented code

@@ -32,11 +32,11 @@ CONFIG_NET_PKT_TX_COUNT=8
# tuned for performance, but this will be revisited in the future.
CONFIG_NET_BUF_RX_COUNT=16
CONFIG_NET_BUF_TX_COUNT=16
CONFIG_NET_BUF_DATA_SIZE=128
CONFIG_NET_BUF_DATA_SIZE=1500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? Default config is only for ping

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 14, 2024
@krish2718
Copy link
Contributor

Migrated to upstream zephyrproject-rtos/zephyr#78588

@krish2718 krish2718 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-nrfxlib Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants