scripts: add script to generate the comparator silabs-acmp bindings h… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedberg
reviewed
Jan 21, 2025
silabs-chgalant
force-pushed
the
scripts/gen-comparator
branch
from
edd088f to
156c894
Compare
jhedberg
approved these changes
Jan 22, 2025
jhedberg
requested changes
Jan 22, 2025
silabs-chgalant
force-pushed
the
scripts/gen-comparator
branch
from
156c894 to
d6227b1
Compare
jhedberg
approved these changes
Jan 22, 2025
|
@asmellby @jerome-pouiller I suppose this is ready to be merged? Seems like the counterpart zephyrproject-rtos/zephyr#83980 is also close to being merged. (No strong opinion on tying these together through an immediate |
|
Btw, since we're starting to have quite many of these import/generation scripts, would it make sense to have some "super script" that covers all of them for a new SiSDK version? |
asmellby
reviewed
Jan 31, 2025
jerome-pouiller
approved these changes
Jan 31, 2025
…eader The script added will combine all possible ACMP positive and negative input values and define helper macros to make it easier for applications to select ACMP inputs for their comparator driver. The script also verifies that the integer input values are consistent between the parts that this header is generated for. However, it must be noted that some of the input defines may not be available as positive and/or negative inputs for some devices. It's recommended to always reference your part's design book before selecting any of the inputs in this generated header. Signed-off-by: Christian Galante <[email protected]>
silabs-chgalant
force-pushed
the
scripts/gen-comparator
branch
from
d6227b1 to
dde6f86
Compare
asmellby
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eader
The script added will combine all possible ACMP positive and negative input values and define helper macros to make it easier for applications to select ACMP inputs for their comparator driver. The script also verifies that the integer input values are consistent between the parts that this header is generated for. However, it must be noted that some of the input defines may not be available as positive and/or negative inputs for some devices. It's recommended to always reference your part's design book before selecting any of the inputs in this generated header.