Drivers: comparator: silabs_acmp implementation #83980

silabs-chgalant · 2025-01-14T22:49:57Z

This pull request does the following:

Enables the hal_silabs ACMP module to be compiled for series 2.
Adds a generated bindings header to aid with acmp input selection
Defines a compatible binding which can be used for series 2 parts that have an acmp peripheral
Instantiates the xg2x parts with an acmp peripheral with an acmp node in their respective part dts
Implements the comparator driver compatible with silabs,acmp
Adds support for the comparator driver in the relevant series 2 development kits and radio boards.
Extends the comparator gpio_loopback tests for xg24_dk2601b and xg29_rb4412a boards.
Extends comparator build testing for all current series 2 boards that support the comparator.

The input-positive and input-negative properties of the silabs,acmp compatible binding are part specific, therefore binding headers are generated per part (as per @asmellby's feedback). However, since most of the input values are common between parts, and there is no overlapping of input values, it was decided (as per @jerome-pouiller's feedback) that we compile the total set of possible ACMP inputs into a single bindings header for the silabs_acmp. It would therefore be up to the user to reference their part's design book when selecting the input-positive and input-negative values for their application.

github-actions · 2025-01-14T22:50:35Z

Hello @silabs-chgalant, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

drivers/comparator/comparator_silabs_acmp.c

dts/bindings/comparator/silabs,acmp.yaml

drivers/comparator/comparator_silabs_acmp.c

modules/hal_silabs/gecko/CMakeLists.txt

drivers/comparator/Kconfig.silabs_acmp

drivers/comparator/comparator_silabs_acmp.c

drivers/comparator/CMakeLists.txt

boards/silabs/dev_kits/xg24_dk2601b/xg24_dk2601b.yaml

dts/bindings/comparator/silabs,acmp.yaml

include/zephyr/dt-bindings/acmp/silabs/xg21-acmp.h

dts/arm/silabs/efr32bg27.dtsi

boards/silabs/dev_kits/xg24_dk2601b/xg24_dk2601b.yaml

jerome-pouiller · 2025-01-17T10:41:30Z

include/zephyr/dt-bindings/acmp/silabs/xg21-acmp.h

+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * This file was generated by the script gen_acmp.py in the hal_silabs module.


I assume you are going to send a PR to hal_silabs to publish gen_acmp.py? Ideally, this current PR should update the reference in west.yml.

Yes, I will open a PR in hal_silabs for that script shortly, then update the reference in west.yml once that gets merged.

I've opened the PR for hal_silabs here zephyrproject-rtos/hal_silabs#80 (cc @asmellby)

include/zephyr/dt-bindings/acmp/silabs/xg21-acmp.h

drivers/comparator/comparator_silabs_acmp.c

jerome-pouiller · 2025-01-20T16:59:30Z

I believe this PR is no more a draft.

bjarki-andreasen · 2025-01-20T21:22:17Z

Looks good :) could you extend the test suite https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/comparator/gpio_loopback with the new comparator and test it out locally as well? and extend https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/build_all/comparator? That allows CI to build various configurations for various boards too :)

silabs-chgalant · 2025-01-21T21:59:25Z

Looks good :) could you extend the test suite https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/comparator/gpio_loopback with the new comparator and test it out locally as well? and extend https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/build_all/comparator? That allows CI to build various configurations for various boards too :)

Thank you for the review!

I'm in the process of extending these tests, I will let you know when this work has been pushed.

drivers/comparator/comparator_silabs_acmp.c

silabs-chgalant · 2025-01-31T17:34:17Z

@Martinhoff-maker @jerome-pouiller @bjarki-andreasen, I pushed a fix for the copyright declarations.

jerome-pouiller · 2025-01-31T17:40:01Z

drivers/comparator/Kconfig.silabs_acmp

@@ -0,0 +1,12 @@
+# Copyright (c) 2025 Silicon Labs Inc.


In fact, we tend to use "Silicon Laboratories Inc." 🙄

Woops... okay I'll try again 😅

Defines bindings that are compatible with silabs acmp. `input-positive` and `input-negative` are required properties to be configured by an application. It is recommended to use the bindings generated in `include/zephyr/dt-bindings/comparator/silabs_acmp.h` and reference your part's design book when configuring values for these properties. Signed-off-by: Christian Galante <[email protected]>

Defines an acmp node for xg21, xg23, xg24, xg27 and xg29 parts, which are all compatible with the silabs,acmp binding. Signed-off-by: Christian Galante <[email protected]>

This implements the comparator driver for silabs acmp peripherals using the silabs,acmp compatible binding. Signed-off-by: Christian Galante <[email protected]>

The xg24_dk2601b, xg24_ek2703a, xg27_dk2602a, xg23_rb4210a, xg24_rb4187c and xg29_rb4412a board yaml files were updated to support the comparator driver. Documentation hardware support was updated for each of these boards as well to mention support for the ACMP hardware block and comparator driver. Signed-off-by: Christian Galante <[email protected]>

…ards Add board overlays to execute the comparator gpio_loopback testsuite on xg24_dk2601b and xg29_rb4412a. The testsuite was executed and was seen to pass on both boards locally with twister. Signed-off-by: Christian Galante <[email protected]>

…tions Add build test configurations for the silabs_acmp comparator. Enable this build testing on all series 2 silabs boards that currently support the comparator driver. Signed-off-by: Christian Galante <[email protected]>

jhedberg · 2025-02-03T09:09:32Z

@bjarki-andreasen looks like this should be ready to go in - just missing your review/approval. Thanks!

bjarki-andreasen

Nice work!

github-actions · 2025-02-03T10:17:37Z

Hi @silabs-chgalant!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

asmellby reviewed Jan 15, 2025

View reviewed changes

jerome-pouiller reviewed Jan 16, 2025

View reviewed changes

jerome-pouiller mentioned this pull request Jan 16, 2025

drivers: sensors: silabs: add gecko acmp #83531

Draft

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from 0c45311 to 3ae5eec Compare January 16, 2025 18:29

This comment was marked as outdated.

Sign in to view

silabs-chgalant commented Jan 16, 2025

View reviewed changes

boards/silabs/dev_kits/xg24_dk2601b/xg24_dk2601b.yaml Show resolved Hide resolved

silabs-chgalant commented Jan 16, 2025

View reviewed changes

dts/bindings/comparator/silabs,acmp.yaml Outdated Show resolved Hide resolved

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from 3ae5eec to 280e2c1 Compare January 16, 2025 20:47

jerome-pouiller self-requested a review January 17, 2025 08:27

asmellby reviewed Jan 17, 2025

View reviewed changes

jerome-pouiller reviewed Jan 17, 2025

View reviewed changes

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch 3 times, most recently from db4001c to 966b99e Compare January 20, 2025 15:39

jerome-pouiller previously approved these changes Jan 20, 2025

View reviewed changes

silabs-chgalant marked this pull request as ready for review January 20, 2025 18:07

zephyrbot added area: Comparator platform: Silabs Silicon Labs labels Jan 20, 2025

zephyrbot requested review from bjarki-andreasen, jhedberg, mnkp, rettichschnidi and yonsch January 20, 2025 18:08

zephyrbot assigned bjarki-andreasen Jan 20, 2025

silabs-chgalant dismissed jerome-pouiller’s stale review via be20548 January 22, 2025 21:38

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from 966b99e to be20548 Compare January 22, 2025 21:38

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from b01d533 to 676ed91 Compare January 31, 2025 16:22

zephyrbot requested a review from Martinhoff-maker January 31, 2025 16:23

jerome-pouiller previously approved these changes Jan 31, 2025

View reviewed changes

silabs-chgalant requested a review from asmellby January 31, 2025 16:48

Martinhoff-maker approved these changes Jan 31, 2025

View reviewed changes

drivers/comparator/comparator_silabs_acmp.c Outdated Show resolved Hide resolved

bjarki-andreasen previously approved these changes Jan 31, 2025

View reviewed changes

silabs-chgalant dismissed stale reviews from bjarki-andreasen and jerome-pouiller via 2cdc1cf January 31, 2025 17:31

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from 676ed91 to 2cdc1cf Compare January 31, 2025 17:31

silabs-chgalant requested review from Martinhoff-maker, bjarki-andreasen and jerome-pouiller January 31, 2025 17:31

jerome-pouiller reviewed Jan 31, 2025

View reviewed changes

silabs-chgalant added 6 commits January 31, 2025 12:47

dts: arm: silabs: instantiate acmp nodes for xg2x parts

096af5c

Defines an acmp node for xg21, xg23, xg24, xg27 and xg29 parts, which are all compatible with the silabs,acmp binding. Signed-off-by: Christian Galante <[email protected]>

drivers: comparator: implement the silabs_acmp compatible driver

2444f44

This implements the comparator driver for silabs acmp peripherals using the silabs,acmp compatible binding. Signed-off-by: Christian Galante <[email protected]>

silabs-chgalant force-pushed the drivers/comparator/gecko-acmp-implementation branch from 2cdc1cf to c54a8db Compare January 31, 2025 17:48

silabs-chgalant requested a review from jerome-pouiller January 31, 2025 17:48

jerome-pouiller approved these changes Feb 1, 2025

View reviewed changes

jhedberg approved these changes Feb 1, 2025

View reviewed changes

asmellby approved these changes Feb 3, 2025

View reviewed changes

Martinhoff-maker approved these changes Feb 3, 2025

View reviewed changes

bjarki-andreasen approved these changes Feb 3, 2025

View reviewed changes

kartben merged commit 2fdfa97 into zephyrproject-rtos:main Feb 3, 2025
30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drivers: comparator: silabs_acmp implementation #83980

Drivers: comparator: silabs_acmp implementation #83980

silabs-chgalant commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025

This comment was marked as outdated.

jerome-pouiller Jan 17, 2025

silabs-chgalant Jan 17, 2025

silabs-chgalant Jan 17, 2025

jerome-pouiller commented Jan 20, 2025

bjarki-andreasen commented Jan 20, 2025 •

edited

Loading

silabs-chgalant commented Jan 21, 2025

silabs-chgalant commented Jan 31, 2025

jerome-pouiller Jan 31, 2025

silabs-chgalant Jan 31, 2025

jhedberg commented Feb 3, 2025

bjarki-andreasen left a comment

github-actions bot commented Feb 3, 2025

Drivers: comparator: silabs_acmp implementation #83980

Drivers: comparator: silabs_acmp implementation #83980

Conversation

silabs-chgalant commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025

This comment was marked as outdated.

jerome-pouiller Jan 17, 2025

Choose a reason for hiding this comment

silabs-chgalant Jan 17, 2025

Choose a reason for hiding this comment

silabs-chgalant Jan 17, 2025

Choose a reason for hiding this comment

jerome-pouiller commented Jan 20, 2025

bjarki-andreasen commented Jan 20, 2025 • edited Loading

silabs-chgalant commented Jan 21, 2025

silabs-chgalant commented Jan 31, 2025

jerome-pouiller Jan 31, 2025

Choose a reason for hiding this comment

silabs-chgalant Jan 31, 2025

Choose a reason for hiding this comment

jhedberg commented Feb 3, 2025

bjarki-andreasen left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2025

silabs-chgalant commented Jan 14, 2025 •

edited

Loading

bjarki-andreasen commented Jan 20, 2025 •

edited

Loading