Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blade with transparency and exclusive fullscreen fixes #10880

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Apr 23, 2024

Release Notes:

  • N/A

Picks up kvark/blade#113 and a bunch of other fixes.
Should prevent the exclusive full-screen on Vulkan - related to #9728
cc @kazatsuyu

Note: this PR doesn't enable transparency, this is left to follow-up

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 23, 2024
@kvark kvark force-pushed the blade-update branch 6 times, most recently from 1a02f22 to 7b9b5d8 Compare April 23, 2024 14:28
@mikayla-maki mikayla-maki merged commit 53f67a8 into zed-industries:main Apr 24, 2024
9 checks passed
@mikayla-maki
Copy link
Contributor

Thank you!

@kvark kvark deleted the blade-update branch April 25, 2024 04:49
@kvark kvark mentioned this pull request Apr 25, 2024
8 tasks
mikayla-maki pushed a commit that referenced this pull request May 6, 2024
Release Notes:

- N/A

Following up to #10880
TODO:
- [x] create window as transparent
  - [x] X11
  - [x] Wayland
  - [ ] Windows
  - [x] MacOS (when used with Blade)  
- [x] enable GPU surface transparency
- [x] adjust the pipeline blend modes
- [x] adjust shader outputs


![transparency2](https://github.com/zed-industries/zed/assets/107301/d554a41b-5d3f-4420-a857-c64c1747c2d5)

Blurred results from @jansol (on Wayland), who contributed to this work:


![zed-blur](https://github.com/zed-industries/zed/assets/107301/a6822171-2dcf-4109-be55-b75557c586de)

---------

Co-authored-by: Jan Solanti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants