-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blade window transparency #10973
Blade window transparency #10973
Conversation
3920df8
to
ec1f3fd
Compare
4d1206e
to
612287b
Compare
aa2c028
to
4f17e87
Compare
Pushed the X11 changes here, but it currently doesn't start. Vulkan surface creation fails with |
bce6916
to
69f786c
Compare
It doesn't like the Visual I'm choosing, for some reason. Here is the visual selected by default, where it works:
And here is the opaque Visual I got by scanning the compatible ones:
Also, here is the transparent Visual I got, which also doesn't work:
I can see that it's not about |
Should be convertible to ext-blur once that is merged more or less by renaming the types.
I got stuck for too long with this issue on X11, which turned out to be quite an adventure! I looked closely at all of the existing X11 examples and also at Blade examples, which worked. Discovered that Finally, I found out that |
Looks great, thank you so much @kvark Also, yikes, that X11 bug looks gnarly. Thanks for tracking that one down :D |
Merging without windows support as we're not officially working on Windows yet. If folks want to follow up, feel free! |
Nice! One minor issue I'm noticing is that the selected item in the file sidebar shows as solid white "experimental.theme_overrides": {
"background.appearance": "blurred",
"background": "#191724BB",
"editor.background": "#00000030",
"editor.gutter.background": "#00000030",
"tab_bar.background": "#00000030",
"terminal.background": "#00000030",
"toolbar.background": "#00000030",
"tab.active_background": "#26233a90",
"tab.inactive_background": "#00000000",
"status_bar.background": "#00000030",
"title_bar.background": "#00000030",
"panel.background": "#00000030",
"border.variant": "#00000000",
"scrollbar.track.border": "#00000000",
"editor.active_line.background": "#00000000"
}, |
Fixes #10973 (comment) Release Notes: - N/A
Release Notes:
Following up to #10880
TODO:
Blurred results from @jansol (on Wayland), who contributed to this work: