Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle changes of portion RuntimeFeatures in actualizers #13597

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swalrus1
Copy link
Collaborator

  • add test
  • handle portion runtime features changes in actualizers

Changelog entry

Fix handling of portion RuntimeFeatures changes in CS actualizers

Changelog category

  • Bugfix

Additional information

  • Fix portions not being actualized sometimes after Optimized is changed
  • Fix VERIFY in tiering actualizer when Optimized is changed

@swalrus1 swalrus1 requested a review from a team as a code owner January 20, 2025 15:45
Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 15:46:42 UTC Pre-commit check linux-x86_64-release-asan for 3a8bd8d has started.
2025-01-20 15:46:53 UTC Artifacts will be uploaded here
2025-01-20 15:49:49 UTC ya make is running...
2025-01-20 15:50:41 UTC Check cancelled

Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 15:46:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3a8bd8d has started.
2025-01-20 15:47:01 UTC Artifacts will be uploaded here
2025-01-20 15:50:05 UTC ya make is running...
2025-01-20 15:50:41 UTC Check cancelled

Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 15:53:46 UTC Pre-commit check linux-x86_64-release-asan for 48314ec has started.
2025-01-20 15:53:53 UTC Artifacts will be uploaded here
2025-01-20 15:56:54 UTC ya make is running...
🟡 2025-01-20 17:03:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11790 11698 0 24 36 32

2025-01-20 17:04:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-20 17:16:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 83 0 2 18 27

2025-01-20 17:16:51 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-20 17:28:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 46 0 0 1 23

🟢 2025-01-20 17:29:00 UTC Build successful.
🟢 2025-01-20 17:29:28 UTC ydbd size 3.6 GiB changed* by +57.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7c328ef merge: 48314ec diff diff %
ydbd size 3 853 082 912 Bytes 3 853 141 800 Bytes +57.5 KiB +0.002%
ydbd stripped size 1 346 233 456 Bytes 1 346 244 208 Bytes +10.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 20, 2025

2025-01-20 15:54:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 48314ec has started.
2025-01-20 15:55:02 UTC Artifacts will be uploaded here
2025-01-20 15:57:57 UTC ya make is running...
🟡 2025-01-20 16:55:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26006 23485 0 6 2395 120

2025-01-20 16:57:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-20 17:10:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 88 0 0 0 117

🟢 2025-01-20 17:10:40 UTC Build successful.
🟢 2025-01-20 17:11:01 UTC ydbd size 2.1 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5aec4ca merge: 48314ec diff diff %
ydbd size 2 216 683 768 Bytes 2 216 703 192 Bytes +19.0 KiB +0.001%
ydbd stripped size 468 637 456 Bytes 468 638 416 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 linked an issue Jan 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data is not evicted unless tiering is reconfigured
1 participant