-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change some event scopes from struct
to namespace
#10685
Conversation
4b688f3
to
77bdc68
Compare
77bdc68
to
5971b51
Compare
5971b51
to
56dbe49
Compare
56dbe49
to
2daaa51
Compare
2daaa51
to
8a03473
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
8a03473
to
1436bcb
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
That requre changing event definition scopes from `struct` to `namespace`.
1436bcb
to
d9c9713
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…11655) Switch `schemeshard_operation_part.h` to forward declarations of component events. Move component specific header includes from `schemeshard_operation_part.h` to relevant suboperation modules. Event definitions often use component specific types and definitions which require dragging along component specific headers. As a result, any schemeshard suboperation module (which have to include base header `schemeshard_operation_part.h`) transitively include headers from all components for all scheme suboperations. Which is a bit excessive. Made possible by #10685. This is part of "improve schemeshard operation build-time" effort (#10633).
Change event scopes from struct to namespace.
Only for those components, which events are used by schemeshard and in scheme operations.
When event classes are declared as inner classes of a
struct
, it is impossible to make forward declarations of those classes (without refactoring all those definitions in a very specific way). Changing event scope fromstruct
tonamespace
enables easy forwarding of its event classes. And that is just a renaming and not a refactoring (no nontrivial changes).Scopes changed:
TEvBlobDepot
TEvBlockStore
TEvColumnShard
TEvConfigsDispatcher
TEvConsole
TEvDataShard
TEvFileStore
TEvHive
TEvKesus
TEvPersQueue
TEvSchemeShard
TEvSequenceShard
TEvSubDomain
This is part of "improve schemeshard operation build-time" effort (#10633).
Changelog category