Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change some event scopes from struct to namespace #10685

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Oct 21, 2024

Change event scopes from struct to namespace.

Only for those components, which events are used by schemeshard and in scheme operations.

When event classes are declared as inner classes of a struct, it is impossible to make forward declarations of those classes (without refactoring all those definitions in a very specific way). Changing event scope from struct to namespace enables easy forwarding of its event classes. And that is just a renaming and not a refactoring (no nontrivial changes).

Scopes changed:

  • TEvBlobDepot
  • TEvBlockStore
  • TEvColumnShard
  • TEvConfigsDispatcher
  • TEvConsole
  • TEvDataShard
  • TEvFileStore
  • TEvHive
  • TEvKesus
  • TEvPersQueue
  • TEvSchemeShard
  • TEvSequenceShard
  • TEvSubDomain

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

@ijon ijon requested review from a team as code owners October 21, 2024 19:05
@ijon ijon requested a review from FloatingCrowbar October 21, 2024 19:05
@ijon ijon force-pushed the event-namespaces branch from 4b688f3 to 77bdc68 Compare October 21, 2024 19:05
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 21, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 21, 2024
@ijon ijon force-pushed the event-namespaces branch from 77bdc68 to 5971b51 Compare October 21, 2024 19:45
@ijon ijon marked this pull request as draft October 21, 2024 19:46
@ijon ijon force-pushed the event-namespaces branch from 5971b51 to 56dbe49 Compare October 21, 2024 19:51
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 21, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 21, 2024
@ijon ijon force-pushed the event-namespaces branch from 56dbe49 to 2daaa51 Compare October 22, 2024 08:20
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 22, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 22, 2024
@ijon ijon force-pushed the event-namespaces branch from 2daaa51 to 8a03473 Compare October 22, 2024 11:15

This comment was marked as outdated.

This comment was marked as outdated.

@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 22, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Oct 22, 2024
@ijon ijon force-pushed the event-namespaces branch from 8a03473 to 1436bcb Compare October 24, 2024 11:38
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 11:41:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a9115a has started.
2024-10-24 11:41:52 UTC Artifacts will be uploaded here
2024-10-24 11:45:05 UTC ya make is running...
🟡 2024-10-24 13:04:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41431 35828 0 2 5503 98

2024-10-24 13:08:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-24 13:20:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 6 0 0 1 93

🟢 2024-10-24 13:20:13 UTC Build successful.
🟢 2024-10-24 13:21:47 UTC ydbd size 2.8 GiB changed* by -5.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 76efe46 merge: 0a9115a diff diff %
ydbd size 3 032 440 840 Bytes 3 032 435 352 Bytes -5.4 KiB -0.000%
ydbd stripped size 480 963 128 Bytes 480 962 616 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 11:41:54 UTC Pre-commit check linux-x86_64-release-asan for 0a9115a has started.
2024-10-24 11:42:04 UTC Artifacts will be uploaded here
2024-10-24 11:45:20 UTC ya make is running...
🟡 2024-10-24 13:29:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11581 11384 0 51 47 99

🟢 2024-10-24 13:30:21 UTC Build successful.
🟢 2024-10-24 13:30:57 UTC ydbd size 5.7 GiB changed* by -9.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 76efe46 merge: 0a9115a diff diff %
ydbd size 6 135 181 936 Bytes 6 135 172 664 Bytes -9.1 KiB -0.000%
ydbd stripped size 1 531 700 304 Bytes 1 531 697 744 Bytes -2.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon marked this pull request as ready for review October 24, 2024 19:06
@ijon ijon requested a review from a team as a code owner October 24, 2024 19:06
@ijon ijon requested review from CyberROFL and removed request for FloatingCrowbar October 28, 2024 14:01
That requre changing event definition scopes from `struct` to `namespace`.
@ijon ijon force-pushed the event-namespaces branch from 1436bcb to d9c9713 Compare October 28, 2024 14:07
Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 14:11:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for f4ebf57 has started.
2024-10-28 14:11:41 UTC Artifacts will be uploaded here
2024-10-28 14:15:28 UTC ya make is running...
🟡 2024-10-28 15:34:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41475 35824 0 11 5541 99

2024-10-28 15:38:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-28 15:50:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 15 0 1 0 94

2024-10-28 15:50:11 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-28 16:01:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 3 0 0 0 92

🟢 2024-10-28 16:01:30 UTC Build successful.
🟢 2024-10-28 16:01:53 UTC ydbd size 2.8 GiB changed* by -5.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a0b88ca merge: f4ebf57 diff diff %
ydbd size 3 033 928 592 Bytes 3 033 923 120 Bytes -5.3 KiB -0.000%
ydbd stripped size 480 683 352 Bytes 480 682 840 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 14:11:37 UTC Pre-commit check linux-x86_64-release-asan for f4ebf57 has started.
2024-10-28 14:11:47 UTC Artifacts will be uploaded here
2024-10-28 14:15:09 UTC ya make is running...
🟡 2024-10-28 15:48:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10777 10613 0 44 20 100

🟢 2024-10-28 15:49:10 UTC Build successful.
🟢 2024-10-28 15:49:41 UTC ydbd size 5.7 GiB changed* by -13.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a0b88ca merge: f4ebf57 diff diff %
ydbd size 6 139 741 040 Bytes 6 139 727 672 Bytes -13.1 KiB -0.000%
ydbd stripped size 1 532 103 472 Bytes 1 532 096 816 Bytes -6.5 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon requested review from alexnick88 and zverevgeny October 28, 2024 14:54
@ijon ijon merged commit 6951a91 into ydb-platform:main Oct 29, 2024
10 checks passed
@ijon ijon deleted the event-namespaces branch October 29, 2024 15:58
This was referenced Nov 1, 2024
ijon added a commit that referenced this pull request Nov 20, 2024
…11655)

Switch `schemeshard_operation_part.h` to forward declarations of component events.
Move component specific header includes from `schemeshard_operation_part.h` to relevant suboperation modules.

Event definitions often use component specific types and definitions which require dragging along component specific headers. As a result, any schemeshard suboperation module (which have to include base header `schemeshard_operation_part.h`) transitively include headers from all components for all scheme suboperations. Which is a bit excessive.

Made possible by #10685.

This is part of "improve schemeshard operation build-time" effort (#10633).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants