Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemeshard: forward declare events in a core header for operations #11655

Merged

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Nov 15, 2024

Switch schemeshard_operation_part.h to forward declarations of component events.
Move component specific header includes from schemeshard_operation_part.h to relevant suboperation modules.

Event definitions often use component specific types and definitions which require dragging along component specific headers. As a result, any schemeshard suboperation module (which have to include base header schemeshard_operation_part.h) transitively include headers from all components for all scheme suboperations. Which is a bit excessive.

Made possible by #10685.

This is part of "improve schemeshard operation build-time" effort (#10633).

Changelog category

  • Not for changelog

Copy link

github-actions bot commented Nov 15, 2024

2024-11-15 11:22:32 UTC Pre-commit check linux-x86_64-release-asan for f040c80 has started.
2024-11-15 11:23:08 UTC Artifacts will be uploaded here
2024-11-15 11:26:49 UTC ya make is running...
🟡 2024-11-15 12:40:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10283 10206 0 23 7 47

🟢 2024-11-15 12:41:21 UTC Build successful.
🟢 2024-11-15 12:41:49 UTC ydbd size 4.9 GiB changed* by -8.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 087c886 merge: f040c80 diff diff %
ydbd size 5 255 200 584 Bytes 5 255 192 376 Bytes -8.0 KiB -0.000%
ydbd stripped size 1 350 173 232 Bytes 1 350 173 168 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 15, 2024

2024-11-15 11:23:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for f040c80 has started.
2024-11-15 11:23:56 UTC Artifacts will be uploaded here
2024-11-15 11:27:13 UTC ya make is running...
🟡 2024-11-15 12:34:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41647 35974 0 3 5558 112

2024-11-15 12:38:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-15 12:50:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 4 0 0 1 109

🟢 2024-11-15 12:50:09 UTC Build successful.
🟢 2024-11-15 12:50:31 UTC ydbd size 2.5 GiB changed* by -7.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 087c886 merge: f040c80 diff diff %
ydbd size 2 681 700 160 Bytes 2 681 692 304 Bytes -7.7 KiB -0.000%
ydbd stripped size 480 770 992 Bytes 480 771 056 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon marked this pull request as ready for review November 15, 2024 14:04
@ijon ijon requested a review from a team as a code owner November 15, 2024 14:04
@ijon ijon requested a review from a-serebryanskiy November 15, 2024 14:04
@ijon ijon requested review from CyberROFL, alexnick88, Enjection and Alek5andr-Kotov and removed request for a-serebryanskiy and alexnick88 November 20, 2024 12:18
@ijon ijon merged commit 2dd1cac into ydb-platform:main Nov 20, 2024
11 checks passed
@ijon ijon deleted the schemeshard-operation-part-forward-declare-events branch November 20, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants