[READY]General CI updates #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
puremourning
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
Switch to ubuntu 24.04 Switch to macos 14 Switch to python 3.9 Install mono-complete Redo valgrind Update actions Use python 3.13 in valgrind run Workaround for cgi module being removed Fix bindings test in newer python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 95.86% 95.92% +0.05%
==========================================
Files 84 84
Lines 8421 8437 +16
Branches 163 163
==========================================
+ Hits 8073 8093 +20
+ Misses 298 294 -4
Partials 50 50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we want to merge this immediately, or wait for october, so that we can actually drop python 3.8.
Quick summary:
This change is