Fix vswhere for Build Tools

[dkaszews]

According to microsoft/vswhere#22, vswhere.exe only finds full Visual Studio IDE instances. To find a naked Build Tools instance, one needs to explicitly add -products 'Microsoft.VisualStudio.Product.BuildTools' to the call, but that won't find IDE instances in turn.

The PR adds the second form as a fallback to support users who only have Build Tools installed without the full IDE.

> ./install.py --skip-build --verbose
Calling C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -latest -property installationVersion
vswhere returned nothing usable: ""
Retrying vswhere for Build Tools
Calling C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -latest -property installationVersion
 -products Microsoft.VisualStudio.Product.BuildTools
vswhere -latest returned version 17.10.35122.118

---

This change is 

[bstaletic]

Thanks for fixing this! I've left two small comments.

Also, the diff is not that bad on Reviewable!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)

---

build.py line 150 at r1 (raw file):

def FindLatestMSVC( quiet, preview=False ):
  ACCEPTABLE_VERSIONS = [ 17, 16, 15 ]

This does not seem to be needed here.

---

build.py line 162 at r1 (raw file):

      vswhere_args.append( '-prerelease' )

    if msvc := UseVsWhere( quiet, vswhere_args ):

:= operator is python 3.9+.
We should hold back just a little longer. Python 3.8 goes EOL in October.

Yes, our CI uses python 3.9, but that's because new ubuntu does not have python 3.8 and I didn't want to drag in pyenv to compile an old version.is_accessible

[dkaszews]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)

---

build.py line 150 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

This does not seem to be needed here.

It is used below for the registry loop. I moved it to file scope to remove duplication.

---

build.py line 162 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

:= operator is python 3.9+.
We should hold back just a little longer. Python 3.8 goes EOL in October.

Yes, our CI uses python 3.9, but that's because new ubuntu does not have python 3.8 and I didn't want to drag in pyenv to compile an old version.is_accessible

Walrus was introduced in 3.8: https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions

[bstaletic]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)

---

build.py line 150 at r1 (raw file):

Previously, dkaszews (Dominik Kaszewski) wrote…

It is used below for the registry loop. I moved it to file scope to remove duplication.

That was outside the diff. Yeah, let's move it to the file scope, with a better name for context.

I'm just not seeing the second push in the diff.

---

build.py line 162 at r1 (raw file):

Previously, dkaszews (Dominik Kaszewski) wrote…

Walrus was introduced in 3.8: https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions

So it is. Nevermind.

[dkaszews]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)

---

build.py line 150 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

That was outside the diff. Yeah, let's move it to the file scope, with a better name for context.

I'm just not seeing the second push in the diff.

Pushed now, was having some connection issues

[bstaletic]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @dkaszews)

[bstaletic]

Turns out i did not merge the CI pull request when I thought I had.
Now that #1746 has been merged, please rebase again.

[dkaszews]

Rebased again

[bstaletic]

Reviewed all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @dkaszews)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (74a5e71) to head (6f1f4f8).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   95.49%   95.87%   +0.38%     
==========================================
  Files          52       84      +32     
  Lines        6947     8437    +1490     
  Branches        0      163     +163     
==========================================
+ Hits         6634     8089    +1455     
+ Misses        313      298      -15     
- Partials        0       50      +50     

[mergify]

Thanks for sending a PR!