-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB subscription #114
Merged
Merged
Add DB subscription #114
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
package db | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"time" | ||
|
||
"go.uber.org/zap" | ||
) | ||
|
||
type PollableDBQuery[ValueType any] func(ctx context.Context, lastSeenID int64, numRows int32) (results []ValueType, lastID int64, err error) | ||
|
||
// Poll whenever notified, or at an interval if not notified | ||
type PollingOptions struct { | ||
Interval time.Duration | ||
Notifier <-chan bool | ||
NumRows int32 | ||
} | ||
|
||
type DBSubscription[ValueType any] struct { | ||
ctx context.Context | ||
log *zap.Logger | ||
lastSeenID int64 | ||
options PollingOptions | ||
query PollableDBQuery[ValueType] | ||
updates chan<- []ValueType | ||
} | ||
|
||
func NewDBSubscription[ValueType any]( | ||
ctx context.Context, | ||
log *zap.Logger, | ||
query PollableDBQuery[ValueType], | ||
lastSeenID int64, | ||
options PollingOptions, | ||
) *DBSubscription[ValueType] { | ||
return &DBSubscription[ValueType]{ | ||
ctx: ctx, | ||
log: log, | ||
lastSeenID: lastSeenID, | ||
options: options, | ||
query: query, | ||
updates: nil, | ||
} | ||
} | ||
|
||
func (s *DBSubscription[ValueType]) Start() (<-chan []ValueType, error) { | ||
if s.updates != nil { | ||
return nil, fmt.Errorf("Already started") | ||
} | ||
if s.options.NumRows <= 0 || s.log == nil { | ||
return nil, fmt.Errorf("Required params not provided") | ||
} | ||
updates := make(chan []ValueType) | ||
s.updates = updates | ||
|
||
go func() { | ||
s.poll() | ||
|
||
timer := time.NewTimer(s.options.Interval) | ||
for { | ||
timer.Reset(s.options.Interval) | ||
select { | ||
case <-s.ctx.Done(): | ||
s.log.Info("Context done; stopping subscription") | ||
close(s.updates) | ||
return | ||
case <-s.options.Notifier: | ||
neekolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
s.poll() | ||
case <-timer.C: | ||
s.poll() | ||
neekolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
}() | ||
|
||
return updates, nil | ||
} | ||
|
||
func (s *DBSubscription[ValueType]) poll() { | ||
// Repeatedly query page by page until no more results | ||
for { | ||
results, lastID, err := s.query(s.ctx, s.lastSeenID, s.options.NumRows) | ||
if err != nil { | ||
s.log.Error( | ||
"Error querying for DB subscription", | ||
zap.Error(err), | ||
zap.Int64("lastSeenID", s.lastSeenID), | ||
zap.Int32("numRows", s.options.NumRows), | ||
) | ||
// Did not update lastSeenID; will retry on next poll | ||
break | ||
} | ||
if len(results) == 0 { | ||
break | ||
} | ||
s.lastSeenID = lastID | ||
s.updates <- results | ||
if int32(len(results)) < s.options.NumRows { | ||
break | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to the PR, but who generates the sequence ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question - the originator does, this would be extracted from the
originator_sid
field ofUnsignedOriginatorEnvelope
proto.As for how the originator allocates these ID's in the first place, it is created by the
BIGSERIAL id
field of thestaged_originator_envelope
table - so we're using a postgres sequence for this.