Add DB subscription #114
Merged
Add DB subscription #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @richardhuaaa and the rest of your teammates on |
This was referenced Aug 21, 2024
Merged
richardhuaaa
force-pushed
the
08-20-add_queries_and_sprocs
branch
3 times, most recently
from
966eb8b to
b342aa5
Compare
richardhuaaa
force-pushed
the
08-20-add_db_subscription
branch
from
647b702 to
92f5ac8
Compare
neekolas
reviewed
Aug 21, 2024
richardhuaaa
force-pushed
the
08-20-add_db_subscription
branch
3 times, most recently
from
a100969 to
4467348
Compare
richardhuaaa
force-pushed
the
08-20-add_db_subscription
branch
from
4467348 to
db44f65
Compare
mkysel
reviewed
Aug 26, 2024
| OR topic = @topic) | ||
| AND (sqlc.narg('originator_node_id')::INT IS NULL | ||
| OR originator_node_id = @originator_node_id) | ||
| AND (sqlc.narg('originator_sequence_id')::BIGINT IS NULL |
There was a problem hiding this comment.
unrelated to the PR, but who generates the sequence ID?
There was a problem hiding this comment.
Great question - the originator does, this would be extracted from the originator_sid field of UnsignedOriginatorEnvelope proto.
As for how the originator allocates these ID's in the first place, it is created by the BIGSERIAL id field of the staged_originator_envelope table - so we're using a postgres sequence for this.
neekolas
reviewed
Aug 26, 2024
neekolas
reviewed
Aug 26, 2024
neekolas
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a struct that can subscribe to changes in a database query, starting from some cursor onwards. Features:
Also adds a flexible DB query against the gateway_envelopes table that can query based on a range of params. Given the size of the query, I should add a unit test for it eventually.