Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return error in reconcile method if child not found #1928

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Tharsanan1
Copy link
Contributor

@Tharsanan1 Tharsanan1 commented Jan 4, 2024

Purpose

$subject
Related to : #1905

@Tharsanan1 Tharsanan1 added the trigger-action When this includes apk actions getting trigger for pr label Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df29018) 28.12% compared to head (ec4fc12) 28.08%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   28.12%   28.08%   -0.05%     
==========================================
  Files         123      123              
  Lines       13932    14009      +77     
  Branches     2567     2567              
==========================================
+ Hits         3918     3934      +16     
- Misses       9881     9940      +59     
- Partials      133      135       +2     
Flag Coverage Δ
adapter 27.08% <ø> (?)
common-controller 4.63% <ø> (?)
config-deployer-service 26.83% <ø> (?)
idp-domain-service 80.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tharsanan1 Tharsanan1 added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Jan 4, 2024
@Krishanx92 Krishanx92 merged commit 2a19d72 into wso2:main Jan 9, 2024
20 of 21 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants