Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API controller should not return err when child not found #1931

Closed
Tharsanan1 opened this issue Jan 5, 2024 · 1 comment
Closed

API controller should not return err when child not found #1931

Tharsanan1 opened this issue Jan 5, 2024 · 1 comment
Assignees
@Tharsanan1
Milestone
1.1.0-m2

Comments

@Tharsanan1
Copy link
Contributor

Currenctly our API controller returns error when a referenced child is not found. This will trigger multiple reconcile requeue events. Since we watch for all the resources we dont have to requeue these unfinished reconcile events.
@Tharsanan1 Tharsanan1 self-assigned this Jan 5, 2024
@Tharsanan1 Tharsanan1 moved this from Backlog to In-Progress in APK Development Jan 5, 2024
@Tharsanan1
Copy link
Contributor Author

PR: #1928

@Tharsanan1 Tharsanan1 moved this from In-Progress to ✅ Done/Done in APK Development Jan 9, 2024
@CrowleyRajapakse CrowleyRajapakse added this to the 1.1.0-m2 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tharsanan1 Tharsanan1

Labels
None yet
Projects
APK Development
Status: ✅ Done/Done
Milestone
1.1.0-m2
Development

No branches or pull requests
2 participants
@CrowleyRajapakse @Tharsanan1