Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPB-15650 update nginx version in join-call pods #16

Open
wants to merge 1 commit into
base: release-5.0
Choose a base branch
from
Open

WPB-15650 update nginx version in join-call pods #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions charts/sftd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,9 @@ tls: {}
joinCall:
replicaCount: 3
image:
repository: nginxinc/nginx-unprivileged
repository: docker.io/bitnami/nginx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that we have the appropriate imagePullSecrets set up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the join-call deployment support imagePullSecrets, if that's what you mean.
this concrete image is public

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking because since DockerHub started imposing rate limits for everything, it turned out to be a good practice to only do authenticated pulls (since unauthenticated pulls have quite a low rate limit per IP).

At least I already got bitten by that rate limit

pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: "1.25.3"
tag: "1.27.3-debian-12-r5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're pinning such a specific tag, wouldn't it also make sense to pin the SHA256?


# Allow SFT instances to choose/consider using a TURN server for themselves as a proxy when
# trying to establish a connection to clients
Expand Down