Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPB-15650 update nginx version in join-call pods #16

Open
wants to merge 1 commit into
base: release-5.0
Choose a base branch
from

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Feb 11, 2025

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

https://wearezeta.atlassian.net/browse/WPB-15649

@smatting smatting requested a review from a team as a code owner February 11, 2025 09:45
@smatting smatting changed the base branch from main to release-5.0 February 11, 2025 09:45
@smatting smatting changed the title release 5.0 update nginx WPB-15650 update nginx version in join-call pods Feb 11, 2025
@@ -83,10 +83,9 @@ tls: {}
joinCall:
replicaCount: 3
image:
repository: nginxinc/nginx-unprivileged
repository: docker.io/bitnami/nginx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that we have the appropriate imagePullSecrets set up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the join-call deployment support imagePullSecrets, if that's what you mean.
this concrete image is public

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking because since DockerHub started imposing rate limits for everything, it turned out to be a good practice to only do authenticated pulls (since unauthenticated pulls have quite a low rate limit per IP).

At least I already got bitten by that rate limit

pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: "1.25.3"
tag: "1.27.3-debian-12-r5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're pinning such a specific tag, wouldn't it also make sense to pin the SHA256?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants