-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPB-15650 update nginx version in join-call pods #16
base: release-5.0
Are you sure you want to change the base?
Conversation
|
@@ -83,10 +83,9 @@ tls: {} | |||
joinCall: | |||
replicaCount: 3 | |||
image: | |||
repository: nginxinc/nginx-unprivileged | |||
repository: docker.io/bitnami/nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that we have the appropriate imagePullSecrets
set up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the join-call deployment support imagePullSecrets, if that's what you mean.
this concrete image is public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking because since DockerHub started imposing rate limits for everything, it turned out to be a good practice to only do authenticated pulls (since unauthenticated pulls have quite a low rate limit per IP).
At least I already got bitten by that rate limit
pullPolicy: IfNotPresent | ||
# Overrides the image tag whose default is the chart appVersion. | ||
tag: "1.25.3" | ||
tag: "1.27.3-debian-12-r5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're pinning such a specific tag, wouldn't it also make sense to pin the SHA256?
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
https://wearezeta.atlassian.net/browse/WPB-15649