Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add support for GH actions Language server #506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FEAT: add support for GH actions Language server #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab2dfa6
FEAT: add support for GH actions Language server
comatory Jan 9, 2025
584b05a
use only `yaml.github` type to launch LSP
comatory Jan 9, 2025
d08d654
Update lua/mason-lspconfig/mappings/filetype.lua
comatory Jan 13, 2025
a6ca268
Update README.md
comatory Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ local DEFAULT_SETTINGS = {
| Fennel | [`fennel_ls`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#fennel_ls) |
| Flux | [`flux_lsp`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#flux_lsp) |
| Fortran | [`fortls`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#fortls) |
| GitHub Actions | [`gh_actions_ls`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.txt#gh_actions_ls) |
| Glimmer | [`glint`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#glint) |
| GLSL | [`glslls`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#glslls) |
| Go | [`ast_grep`](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#ast_grep) |
Expand Down
1 change: 1 addition & 0 deletions doc/mason-lspconfig-mapping.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ flux-lsp flux_lsp
foam-language-server foam_ls
fortls fortls
fsautocomplete fsautocomplete
gh-actions-language-server gh_actions_ls
ginko_ls ginko_ls
gitlab-ci-ls gitlab_ci_ls
glint glint
Expand Down
1 change: 1 addition & 0 deletions doc/server-mapping.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
| [foam_ls](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#foam_ls) | [foam-language-server](https://mason-registry.dev/registry/list#foam-language-server) |
| [fortls](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#fortls) | [fortls](https://mason-registry.dev/registry/list#fortls) |
| [fsautocomplete](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#fsautocomplete) | [fsautocomplete](https://mason-registry.dev/registry/list#fsautocomplete) |
| [gh_actions_ls](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#gh_actions_ls) | [gh-actions-language-server](https://mason-registry.dev/registry/list#gh-actions-language-server) |
| [ginko_ls](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#ginko_ls) | [ginko_ls](https://mason-registry.dev/registry/list#ginko_ls) |
| [gitlab_ci_ls](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#gitlab_ci_ls) | [gitlab-ci-ls](https://mason-registry.dev/registry/list#gitlab-ci-ls) |
| [glint](https://github.com/neovim/nvim-lspconfig/blob/master/doc/configs.md#glint) | [glint](https://mason-registry.dev/registry/list#glint) |
Expand Down
3 changes: 2 additions & 1 deletion lua/mason-lspconfig/mappings/filetype.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,9 @@ return {
["yaml.ansible"] = { "ansiblels" },
["yaml.docker-compose"] = { "docker_compose_language_service", "yamlls" },
["yaml.gitlab"] = { "gitlab_ci_ls", "yamlls" },
["yaml.github"] = { "gh_actions_ls", "yamlls" },
Copy link

@disrupted disrupted Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["yaml.github"] = { "gh_actions_ls", "yamlls" },

now that the filetype has been changed upstream to yaml we should also update it here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update how? the suggestion contains no changes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, original answer updated. The LS needs to be registered for the regular yaml filetype now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be contrary to the advice given here?

["yaml.openapi"] = { "vacuum" },
yml = { "spectral" },
zig = { "zls" },
zir = { "zls" }
}
}
1 change: 1 addition & 0 deletions lua/mason-lspconfig/mappings/server.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ M.lspconfig_to_package = {
["fortls"] = "fortls",
["fsautocomplete"] = "fsautocomplete",
["gitlab_ci_ls"] = "gitlab-ci-ls",
["gh_actions_ls"] = "gh-actions-language-server",
["ginko_ls"] = "ginko_ls",
["glint"] = "glint",
["glsl_analyzer"] = "glsl_analyzer",
Expand Down