FEAT: add support for GH actions Language server #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Github Actions.
disrupted
reviewed
Jan 9, 2025
disrupted
suggested changes
Jan 9, 2025
disrupted
suggested changes
Jan 13, 2025
Co-authored-by: Salomon Popp <[email protected]>
Co-authored-by: Salomon Popp <[email protected]>
disrupted
approved these changes
Jan 13, 2025
disrupted
suggested changes
Jan 17, 2025
| @@ -242,8 +242,9 @@ return { | |||
| ["yaml.ansible"] = { "ansiblels" }, | |||
| ["yaml.docker-compose"] = { "docker_compose_language_service", "yamlls" }, | |||
| ["yaml.gitlab"] = { "gitlab_ci_ls", "yamlls" }, | |||
| ["yaml.github"] = { "gh_actions_ls", "yamlls" }, | |||
There was a problem hiding this comment.
Suggested change
| ["yaml.github"] = { "gh_actions_ls", "yamlls" }, |
now that the filetype has been changed upstream to yaml we should also update it here
There was a problem hiding this comment.
update how? the suggestion contains no changes.
There was a problem hiding this comment.
my bad, original answer updated. The LS needs to be registered for the regular yaml filetype now.
There was a problem hiding this comment.
Wouldn't that be contrary to the advice given here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Github Actions.
Caution
I'm not familiar with the codebase and I've never added such configuration. I could use help on this one.
I tried looking at other PRs to see whether I'm doing it right.