Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps #2878

Merged
merged 3 commits into from
May 20, 2024
Merged

chore: bump deps #2878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0632bc
chore: bump deps
brc-dd May 20, 2024
f900a26
update netlify.toml
brc-dd May 20, 2024
9b62666
remove old pnpm overrides
brc-dd May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.vue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reason we added this? (sorry for being late 😅)

Copy link
Member Author

@brc-dd brc-dd May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier doesn't work properly with vue's template part. Can be reverted though. I don't have any strong preference. I've don't do format on save.

1 change: 1 addition & 0 deletions .vitepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,7 @@ export default defineConfigWithTheme<ThemeConfig>({
markdown: {
theme: 'github-dark',
config(md) {
// @ts-expect-error - broken type output in vitepress
md.use(headerPlugin)
// .use(textAdPlugin)
}
Expand Down
2 changes: 0 additions & 2 deletions .vitepress/headerMdPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ export interface AugmentedHeader extends Header {
}

export const headerPlugin = (md: MarkdownIt) => {
md.core.ruler.enable('text_join')

md.renderer.rules.heading_open = (tokens, i, options, env, self) => {
for (const child of tokens[i + 1].children!) {
if (child.type === 'text' && child.content.endsWith('*')) {
Expand Down
2 changes: 1 addition & 1 deletion .vitepress/theme/components/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { ref, onMounted } from 'vue'
import { onMounted } from 'vue'
import SiteMap from './SiteMap.vue'
// import NewsLetter from './NewsLetter.vue'
import { load, data, base } from './sponsors'
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build.environment]
NODE_VERSION = "16"
NODE_VERSION = "20"

[build]
publish = ".vitepress/dist"
Expand Down
37 changes: 14 additions & 23 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,33 +7,24 @@
"dev": "vitepress",
"build": "vitepress build",
"preview": "vitepress preview",
"preinstall": "npx only-allow pnpm"
"preinstall": "npx only-allow pnpm",
"type": "vue-tsc --noEmit"
},
"dependencies": {
"@vue/repl": "^4.0.1",
"@vue/theme": "^2.2.5",
"@vue/repl": "^4.1.2",
"@vue/theme": "^2.2.8",
"dynamics.js": "^1.1.5",
"gsap": "^3.9.0",
"vitepress": "^1.1.0",
"vue": "^3.4.0"
"gsap": "^3.12.5",
"vitepress": "^1.2.0",
"vue": "^3.4.27"
},
"devDependencies": {
"@types/markdown-it": "^12.2.3",
"@types/node": "^20.10.1",
"terser": "^5.14.2"
"@types/body-scroll-lock": "^3.1.2",
"@types/markdown-it": "^14.1.1",
"@types/node": "^20.12.12",
"terser": "^5.31.0",
"typescript": "^5.4.5",
"vue-tsc": "^2.0.19"
},
"pnpm": {
"overrides": {
"@vitejs/plugin-vue": "5.0.0-beta.1"
},
"peerDependencyRules": {
"ignoreMissing": [
"@algolia/client-search",
"react",
"react-dom",
"@types/react",
"search-insights"
]
}
}
"packageManager": "[email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brc-dd do you think we can skim this rule? Since I guess it breaks the translation deployments on Vercel like docs-cs vuejs-translations/docs-cs#132 (comment)

Copy link
Member Author

@brc-dd brc-dd May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix it on v8 for now. Vercel supports corepack but I think they are blocked on something in pnpm v9. On newer node versions, this is automatically added each time you run a command and have corepack enabled locally (say, for other projects). So removing it each time before you commit is bit of pain. And I think all other projects in the org are already using corepack because of DX improvements, so makes sense to keep it here. Also, the engine fields of most of the translation repos are wrong. vite, vitepress, pnpm don't support node v14.

Copy link
Member Author

@brc-dd brc-dd May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I think v9 is also supported via corepack (but detecting it is not supported). Try setting https://vercel.com/docs/deployments/configure-a-build#corepack ENABLE_EXPERIMENTAL_COREPACK=1 in env variable. Locking to old version can only be a temporary solution I guess.

}
Loading