chore: bump deps #2878
chore: bump deps #2878
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It seems this change may have broken some pages in the docs. e.g. https://vuejs.org/api/sfc-script-setup.html currently won't load, with errors in the console. |
|
I have partially reverted the changes and locked vitepress version back to 1.1. |
| @@ -0,0 +1 @@ | |||
| *.vue | |||
There was a problem hiding this comment.
Any special reason we added this? (sorry for being late 😅)
There was a problem hiding this comment.
Prettier doesn't work properly with vue's template part. Can be reverted though. I don't have any strong preference. I've don't do format on save.
| ] | ||
| } | ||
| } | ||
| "packageManager": "[email protected]" |
There was a problem hiding this comment.
@brc-dd do you think we can skim this rule? Since I guess it breaks the translation deployments on Vercel like docs-cs vuejs-translations/docs-cs#132 (comment)
There was a problem hiding this comment.
We can fix it on v8 for now. Vercel supports corepack but I think they are blocked on something in pnpm v9. On newer node versions, this is automatically added each time you run a command and have corepack enabled locally (say, for other projects). So removing it each time before you commit is bit of pain. And I think all other projects in the org are already using corepack because of DX improvements, so makes sense to keep it here. Also, the engine fields of most of the translation repos are wrong. vite, vitepress, pnpm don't support node v14.
There was a problem hiding this comment.
Or I think v9 is also supported via corepack (but detecting it is not supported). Try setting https://vercel.com/docs/deployments/configure-a-build#corepack ENABLE_EXPERIMENTAL_COREPACK=1 in env variable. Locking to old version can only be a temporary solution I guess.
reverts #2858 (fixed in vitepress and theme)