-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in the codebase #29
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
Signed-off-by: Sayan Banerjee <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @william-wang |
Thanks for your contribution! It's a huge change, maybe we can split it into small PRs? |
Hi @Monokaix I have broken down the long PR into multiple small PRs. Just a point to note is each have high number of deleted lines and added lines. The significant number of deleted lines is due to the removal of |
Hi @Monokaix, is there any update in this PR or anything you want me to do it in? |
This PR solves rest part of the issue #13
Got the types of the custom resources from their definition (https://github.com/volcano-sh/volcano/blob/master/installer/volcano-development.yaml) and used json-schema-to-typescript (https://transform.tools/json-schema-to-typescript) to get their types
Broke backend routes into different files for better understanding
Added a Prettier configuration file to ensure consistent code formatting across the project.
Created a single script to build both frontend and backend.Single script to start production builds
Note this PR is an extension of PR #13. i.e. merging this PR will solve issue #13 other than the tests.
Here is a video to summarise my whole PR
Improvement.in.Codebase.mp4