Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in the codebase #29

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Sayan4444
Copy link
Contributor

@Sayan4444 Sayan4444 commented Feb 17, 2025

This PR solves rest part of the issue #13

  • Transition the entire codebase from javascript to typescript

Got the types of the custom resources from their definition (https://github.com/volcano-sh/volcano/blob/master/installer/volcano-development.yaml) and used json-schema-to-typescript (https://transform.tools/json-schema-to-typescript) to get their types

  • Broke backend routes into different files for better understanding

  • Added a Prettier configuration file to ensure consistent code formatting across the project.

  • Created a single script to build both frontend and backend.Single script to start production builds

Note this PR is an extension of PR #13. i.e. merging this PR will solve issue #13 other than the tests.

Here is a video to summarise my whole PR

Improvement.in.Codebase.mp4

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sayan4444
Copy link
Contributor Author

/assign @william-wang

@Monokaix
Copy link
Member

Thanks for your contribution! It's a huge change, maybe we can split it into small PRs?

@Sayan4444
Copy link
Contributor Author

Hi @Monokaix I have broken down the long PR into multiple small PRs. Just a point to note is each have high number of deleted lines and added lines.

The significant number of deleted lines is due to the removal of package-lock.json files from the frontend and backend directories, while the high number of added lines is attributed to the newly generated package-lock.json at the root of the monorepo. In a monorepo structure, package-lock.json should be maintained only at the root level. While this is not causing any immediate issues, it could lead to potential problems in the future, which may require extensive debugging to resolve.

@Sayan4444
Copy link
Contributor Author

Hi @Monokaix, is there any update in this PR or anything you want me to do it in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants