Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@xen-orchestra/rest-api): setup simple auth middleware #8327

Merged
merged 9 commits into from
Feb 20, 2025

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 10, 2025

Description

Configure dependency injection + configure authentication middleware for openapi (copy of what actually exists in the current REST API. Will be improved later when implementing ACL/resource set)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA self-assigned this Feb 10, 2025
Base automatically changed from setup-openapi to master February 12, 2025 13:09
@MathieuRA MathieuRA force-pushed the setup-auth-openapi branch 2 times, most recently from 6f4edce to 77b63f5 Compare February 17, 2025 08:39
@MathieuRA MathieuRA marked this pull request as ready for review February 17, 2025 10:38
@MathieuRA MathieuRA requested review from b-Nollet and removed request for b-Nollet February 17, 2025 10:39
Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add

@MathieuRA MathieuRA requested a review from fbeauchamp February 20, 2025 13:27
@MathieuRA MathieuRA removed the request for review from fbeauchamp February 20, 2025 13:29
@MathieuRA MathieuRA requested a review from fbeauchamp February 20, 2025 13:33
@fbeauchamp fbeauchamp merged commit 6f5b97f into master Feb 20, 2025
1 check passed
@fbeauchamp fbeauchamp deleted the setup-auth-openapi branch February 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants