-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@xen-orchestra/rest-api): expose get vms and get vm #8356
Open
MathieuRA
wants to merge
13
commits into
master
Choose a base branch
from
swagger-vms
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
reviewed
Feb 19, 2025
Comment on lines
11
to
12
this.getObject = (id, type) => xoApp.getObject(id, type) | ||
this.getObjectsByType = (type, opts) => xoApp.getObjectsByType(type, opts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it work with real methods defined on the class and setting xoa as a private member of Rest Api ?
b-Nollet
approved these changes
Feb 20, 2025
fbeauchamp
reviewed
Feb 20, 2025
Comment on lines
5
to
11
export default function tsoaToXoErrorHandler(error: unknown, _req: Request, _res: Response, next: NextFunction) { | ||
if (!(error instanceof ValidateError)) { | ||
return next(error) | ||
} | ||
|
||
invalidParameters(error.fields) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
export default function tsoaToXoErrorHandler(error: unknown, _req: Request, _res: Response, next: NextFunction) { | |
if (!(error instanceof ValidateError)) { | |
return next(error) | |
} | |
invalidParameters(error.fields) | |
} | |
export default function tsoaToXoErrorHandler(error: unknown, _req: Request, _res: Response, next: NextFunction) { | |
if (error instanceof ValidateError) { | |
return invalidParameters(error.fields) | |
} | |
return next(error) | |
} |
c0bdbd8
to
44cd32e
Compare
fcba89c
to
30ab132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wait for #8327
TSOA
requires importing the type from the root library to generate the OpenAPI specification[number, number]
) throw errors when generating the OpenAPI specification. They have been updated tonumber[]
XapiXoRecord
to be able to differentiate between XO types that come fromxapi-object-to-xo
and XO types that come from XO collectionsgetObjectsByType
to avoid iterating over allXAPI objects
when we know what type of object we wantBranded
is not a valid type for the OpenAPI spec. I created aUnbrand
type, that convert allBranded
tostring
. (UseUnbrand
only for OpenAPI specification definition to maintainBranded
type safety)README.md
to have consistency of order in the use of decoratorsChecklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: