Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: fix logger test #2396

Merged
merged 2 commits into from
Oct 7, 2024
+0 −4
Merged

Java: fix logger test #2396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc91946
Yury-Fridlyand Oct 7, 2024
eb2fc3a
Yury-Fridlyand Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions java/integTest/src/test/java/glide/LoggerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ public void log_to_file() {
// Initialize a new logger to force closing of existing files
String dummyFilename = "dummy.txt";
Logger.setLoggerConfig(Logger.Level.DEFAULT, dummyFilename);
Comment on lines 73 to 74
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are removing all dummy log related tests, why not removing these 2 lines as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still needed (line 72)

File[] dummyLogFiles = logFolder.listFiles((dir, name) -> name.startsWith(dummyFilename + "."));
assertNotNull(dummyLogFiles);
File dummyLogFile = dummyLogFiles[0];

File[] logFiles = logFolder.listFiles((dir, name) -> name.startsWith(filename + "."));
assertNotNull(logFiles);
Expand All @@ -96,7 +93,6 @@ public void log_to_file() {
assertTrue(errorLineLazy.contains(errorIdentifier + " - " + errorMessage));
} finally {
logFile.delete();
dummyLogFile.delete();
logFolder.delete();
}
}
Expand Down
Loading