Java: fix logger test #2396
Merged
Java: fix logger test #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
added
java
jonathanl-bq
approved these changes
Oct 7, 2024
prateek-kumar-improving
approved these changes
Oct 7, 2024
Comment on lines
73
to
74
| String dummyFilename = "dummy.txt"; | ||
| Logger.setLoggerConfig(Logger.Level.DEFAULT, dummyFilename); |
There was a problem hiding this comment.
If we are removing all dummy log related tests, why not removing these 2 lines as well?
There was a problem hiding this comment.
This is still needed (line 72)
acarbonetto
approved these changes
Oct 7, 2024
tjzhang-BQ
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2391 log file isn't created if no writes requested. Test "LoggerTests > log to file" starts to fail on
mainbranch.