limit pr run to ubuntu latest X first and last version supported, add… #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
3 times, most recently
from
e57a2d6 to
98be872
Compare
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
98be872 to
a463403
Compare
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
2 times, most recently
from
217c36b to
d3dd301
Compare
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
d3dd301 to
b2acddf
Compare
There was a problem hiding this comment.
Great job!
Few final steps left:
- Check and fix CI failures or rebase if it is already fixed in another PR(s).
- Eliminate errors and warnings (as much as possible) in CI reports ("Unexpected input(s) 'github-token'", "Node.js 16 actions are deprecated" and so on).
- Merge with changes from Python client CI: Split lint and testing in CI + add reporting. #1976 and Node client CI: Add reporting #1983.
- Update uploaded artifact names if needed.
- Add short instructions to the developer guides or create a new one with common info in the root of the repository.
- Label your PR to see how it works. I think you can un-label an re-label it back to re-run extra CI.
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
2 times, most recently
from
5e01333 to
ddd2ef6
Compare
…ed schedule and label runs Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
ddd2ef6 to
fc4cb44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited the CI to run on PR and PUSH to run just on Ubuntu-latest and latest and last version supported for engine and language version.
Added Schedule run daily, one hour in between each workflow, start from 3 AM, GMT+3.
Added trigger on label "Core changes" that will need team approval to run.
Added all NodeJS versions supported.
In this PR changes worked as expected.