Skip to content

Commit

Permalink
changed to Core changes
Browse files Browse the repository at this point in the history
Signed-off-by: avifenesh <[email protected]>
  • Loading branch information
avifenesh committed Jul 21, 2024
1 parent 77c6e48 commit 98be872
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 27 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,20 @@ concurrency:
jobs:
check-label:
runs-on: ubuntu-latest
# If the trigger is a label we want to check if it is a CoreChanges label,
# If the trigger is a label we want to check if it is a Core changes label,
# if it is we want to run the job in the AWS_ACTIONS environment so its need to be approved
environment: ${{ github.event_name == 'pull_request_target' && 'AWS_ACTIONS' || '' }}
steps:
- name: Check for CoreChanges label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'CoreChanges'
- name: Check for Core changes label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'Core changes'
run: |
echo "This workflow only runs for the CoreChanges label on pull requests"
echo "This workflow only runs for the Core changes label on pull requests"
exit 1
load-engine-matrix:
runs-on: ubuntu-latest
# We want to run this job only if the previous job outputs should_run=true,
# Which means that if the trigger was a label we run this job just if the label was CoreChanges
# Which means that if the trigger was a label we run this job just if the label was Core changes
needs: check-label
outputs:
matrix: ${{ steps.load-engine-matrix.outputs.matrix }}
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:
java/client/build/reports/spotbugs/**
build-amazonlinux-latest:
if: github.repository_owner == 'valkey-io' && (github.event_name == 'schedule' || github.event.label.name == 'CoreChanges')
if: github.repository_owner == 'valkey-io' && (github.event_name == 'schedule' || github.event.label.name == 'Core changes')
strategy:
# Run all jobs
fail-fast: false
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,20 @@ env:
jobs:
check-label:
runs-on: ubuntu-latest
# If the trigger is a label we want to check if it is a CoreChanges label,
# If the trigger is a label we want to check if it is a Core changes label,
# if it is we want to run the job in the AWS_ACTIONS environment so its need to be approved
environment: ${{ github.event_name == 'pull_request_target' && 'AWS_ACTIONS' || '' }}
steps:
- name: Check for CoreChanges label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'CoreChanges'
- name: Check for Core changes label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'Core changes'
run: |
echo "This workflow only runs for the CoreChanges label on pull requests"
echo "This workflow only runs for the Core changes label on pull requests"
exit 1
load-engine-matrix:
runs-on: ubuntu-latest
# We want to run this job only if the previous job outputs should_run=true,
# Which means that if the trigger was a label we run this job just if the label was CoreChanges
# Which means that if the trigger was a label we run this job just if the label was Core changes
needs: check-label
outputs:
matrix: ${{ steps.load-engine-matrix.outputs.matrix }}
Expand All @@ -81,7 +81,7 @@ jobs:
- name: Load the engine matrix
id: load-engine-matrix
shell: bash
# We want to run the full matrix only for scheduled runs and CoreChanges
# We want to run the full matrix only for scheduled runs and Core changes
# For other events we want to run only the always matrix which is first and last version supported
run: |
if [[ "${{ github.event_name }}" == "pull_request" || "${{ github.event_name }}" == "push" ]]; then
Expand All @@ -101,7 +101,7 @@ jobs:
- name: Create version matrix
id: create-version-matrix
shell: bash
# We want to run the full matrix only for scheduled runs and CoreChanges
# We want to run the full matrix only for scheduled runs and Core changes
# For other events we want to run only the always matrix which is first and last version supported
run: |
if [[ "${{ github.event_name }}" == "pull_request" || "${{ github.event_name }}" == "push" ]]; then
Expand All @@ -114,7 +114,7 @@ jobs:
test-ubuntu-latest:
runs-on: ubuntu-latest
needs: [load-engine-matrix, create-version-matrix]
timeout-minutes: 15
timeout-minutes: 25
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
name: lint node rust

build-macos-latest:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
runs-on: macos-latest
needs: check-label
timeout-minutes: 25
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
working-directory: ./node

build-amazonlinux-latest:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
runs-on: ubuntu-latest
container: amazonlinux:latest
needs: check-label
Expand Down Expand Up @@ -250,7 +250,7 @@ jobs:
working-directory: ./node

build-and-test-linux-musl-on-x86:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
name: Build and test Node wrapper on Linux musl
needs: check-label
runs-on: ubuntu-latest
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,20 @@ permissions:
jobs:
check-label:
runs-on: ubuntu-latest
# If the trigger is a label we want to check if it is a CoreChanges label,
# If the trigger is a label we want to check if it is a Core changes label,
# if it is we want to run the job in the AWS_ACTIONS environment so its need to be approved
environment: ${{ github.event_name == 'pull_request_target' && 'AWS_ACTIONS' || '' }}
steps:
- name: Check for CoreChanges label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'CoreChanges'
- name: Check for Core changes label
if: github.event_name == 'pull_request_target' && github.event.label.name != 'Core changes'
run: |
echo "This workflow only runs for the CoreChanges label on pull requests"
echo "This workflow only runs for the Core changes label on pull requests"
exit 1
load-engine-matrix:
runs-on: ubuntu-latest
# We want to run this job only if the previous job outputs should_run=true,
# Which means that if the trigger was a label we run this job just if the label was CoreChanges
# Which means that if the trigger was a label we run this job just if the label was Core changes
needs: check-label
outputs:
matrix: ${{ steps.load-engine-matrix.outputs.matrix }}
Expand All @@ -82,7 +82,7 @@ jobs:
- name: Load the engine matrix
id: load-engine-matrix
shell: bash
# We want to run the full matrix only for scheduled runs and CoreChanges
# We want to run the full matrix only for scheduled runs and Core changes
# For other events we want to run only the always matrix which is first and last version supported
run: |
if [[ "${{ github.event_name }}" == "pull_request" || "${{github.event_name }}" == "push" ]]; then
Expand All @@ -103,7 +103,7 @@ jobs:
id: create-version-matrix

shell: bash
# We want to run the full matrix only for scheduled runs and CoreChanges
# We want to run the full matrix only for scheduled runs and Core changes
# For other events we want to run only the always matrix which is first and last version supported
run: |
if [[ "${{ github.event_name }}" == "pull_request" || "${{github.event_name }}" == "push" ]]; then
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:
name: lint python-rust

test-macos-latest:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
runs-on: macos-latest
needs: load-engine-matrix
timeout-minutes: 35
Expand Down Expand Up @@ -265,7 +265,7 @@ jobs:
pytest --asyncio-mode=auto
test-pubsub-macos-latest:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
runs-on: macos-latest
needs: load-engine-matrix
timeout-minutes: 35
Expand Down Expand Up @@ -296,7 +296,7 @@ jobs:
pytest --asyncio-mode=auto -k test_pubsub
build-amazonlinux-latest:
if: github.event_name == 'schedule' || github.event.label.name == 'CoreChanges'
if: github.event_name == 'schedule' || github.event.label.name == 'Core changes'
runs-on: ubuntu-latest
container: amazonlinux:latest
needs: check-label
Expand Down

0 comments on commit 98be872

Please sign in to comment.