-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(flaky): Increase check timeouts #995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroCabeza
force-pushed
the
flaky-fixes
branch
from
November 30, 2023 15:18
40ec256
to
aa0e7c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #995 +/- ##
============================================
- Coverage 83.17% 83.15% -0.02%
============================================
Files 91 91
Lines 15342 15344 +2
============================================
- Hits 12760 12759 -1
- Misses 2582 2585 +3 |
AlejandroCabeza
force-pushed
the
flaky-fixes
branch
from
January 25, 2024 18:38
94fdf1a
to
f183029
Compare
kaiserd
previously approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlejandroCabeza
force-pushed
the
flaky-fixes
branch
2 times, most recently
from
January 26, 2024 16:36
4a34028
to
1f12086
Compare
AlejandroCabeza
changed the title
tests(flaky): Fix
tests(flaky): Increase check timeouts
Jan 26, 2024
diegomrsantos
approved these changes
Jan 29, 2024
AlejandroCabeza
force-pushed
the
flaky-fixes
branch
from
January 31, 2024 23:02
1af384c
to
cafd509
Compare
AlejandroCabeza
force-pushed
the
flaky-fixes
branch
from
January 31, 2024 23:04
cafd509
to
e3c96dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix flaky tests by increasing the check timeout.
Changes