Add comments to identify failing tests, increase timeouts in some fai…

…ling tests.
vacp2p · Nov 29, 2023 · 40ec256 · 40ec256
1 parent 5f7a3ab
commit 40ec256
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 19 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,3 +16,4 @@ tests/pubsub/testgossipsub
 examples/*.md
 nimble.develop
 nimble.paths
+go-libp2p-daemon/
diff --git a/tests/testdcutr.nim b/tests/testdcutr.nim
@@ -42,6 +42,7 @@ suite "Dcutr":
 
     check syncMsg == syncMsgDecoded
 
+  # FAILS
   asyncTest "DCUtR establishes a new connection":
 
     let behindNATSwitch = newStandardSwitch()
@@ -58,7 +59,7 @@ suite "Dcutr":
       t.networkReachability = NetworkReachability.NotReachable
 
     await DcutrClient.new().startSync(behindNATSwitch, publicSwitch.peerInfo.peerId, behindNATSwitch.peerInfo.addrs)
-    .wait(300.millis)
+    .wait(1000.millis)
 
     checkExpiring:
       # we can't hole punch when both peers are in the same machine. This means that the simultaneous dialings will result
@@ -88,25 +89,28 @@ suite "Dcutr":
 
     await allFutures(behindNATSwitch.stop(), publicSwitch.stop())
 
+  # FAILS
   asyncTest "Client connect timeout":
+    proc connectTimeoutProc(self: SwitchStub,
+                            peerId: PeerId,
+                            addrs: seq[MultiAddress],
+                            forceDial = false,
+                            reuseConnection = true,
+                            upgradeDir = Direction.Out): Future[void] {.async.} =
+      await sleepAsync(100.millis)
+
+    let behindNATSwitch = SwitchStub.new(newStandardSwitch(), connectTimeoutProc)
+    let publicSwitch = newStandardSwitch()
+
+    ductrClientTest(behindNATSwitch, publicSwitch):
 
-     proc connectTimeoutProc(self: SwitchStub,
-                             peerId: PeerId,
-                             addrs: seq[MultiAddress],
-                             forceDial = false,
-                             reuseConnection = true,
-                             upgradeDir = Direction.Out): Future[void] {.async.} =
-       await sleepAsync(100.millis)
-
-     let behindNATSwitch = SwitchStub.new(newStandardSwitch(), connectTimeoutProc)
-     let publicSwitch = newStandardSwitch()
-     ductrClientTest(behindNATSwitch, publicSwitch):
-       try:
-         let client = DcutrClient.new(connectTimeout = 5.millis)
-         await client.startSync(behindNATSwitch, publicSwitch.peerInfo.peerId, behindNATSwitch.peerInfo.addrs)
-       except DcutrError as err:
-         check err.parent of AsyncTimeoutError
+      try:
+        let client = DcutrClient.new(connectTimeout = 5.millis)
+        await client.startSync(behindNATSwitch, publicSwitch.peerInfo.peerId, behindNATSwitch.peerInfo.addrs)
+      except DcutrError as err:
+        check err.parent of AsyncTimeoutError
 
+  # FAILS
   asyncTest "All client connect attempts fail":
 
     proc connectErrorProc(self: SwitchStub,
@@ -143,7 +147,7 @@ suite "Dcutr":
       t.networkReachability = NetworkReachability.NotReachable
 
     await DcutrClient.new().startSync(behindNATSwitch, publicSwitch.peerInfo.peerId, behindNATSwitch.peerInfo.addrs)
-    .wait(300.millis)
+    .wait(1000.millis)
 
     checkExpiring:
       # we can't hole punch when both peers are in the same machine. This means that the simultaneous dialings will result
@@ -152,6 +156,7 @@ suite "Dcutr":
 
     await allFutures(behindNATSwitch.stop(), publicSwitch.stop())
 
+  # FAILS
   asyncTest "DCUtR server timeout when establishing a new connection":
 
     proc connectProc(self: SwitchStub,
@@ -160,10 +165,11 @@ suite "Dcutr":
                      forceDial = false,
                      reuseConnection = true,
                      upgradeDir = Direction.Out): Future[void] {.async.} =
-        await sleepAsync(100.millis)
+        await sleepAsync(1000.millis)
 
     await ductrServerTest(connectProc)
 
+  # FAILS
   asyncTest "DCUtR server error when establishing a new connection":
 
     proc connectProc(self: SwitchStub,

diff --git a/tests/testhpservice.nim b/tests/testhpservice.nim
@@ -55,6 +55,7 @@ suite "Hole Punching":
   teardown:
     checkTrackers()
 
+  # FAILS
   asyncTest "Direct connection must work when peer address is public":
     let autonatClientStub = AutonatClientStub.new(expectedDials = 1)
     autonatClientStub.answer = NotReachable
@@ -96,6 +97,7 @@ suite "Hole Punching":
     await allFuturesThrowing(
       privatePeerSwitch.stop(), publicPeerSwitch.stop(), switchRelay.stop(), peerSwitch.stop())
 
+  # FAILS
   asyncTest "Direct connection must work when peer address is public and dns is used":
 
     let autonatClientStub = AutonatClientStub.new(expectedDials = 1)
@@ -205,6 +207,7 @@ suite "Hole Punching":
       privatePeerSwitch1.stop(), privatePeerSwitch2.stop(), switchRelay.stop(),
       switchAux.stop(), switchAux2.stop(), switchAux3.stop(), switchAux4.stop())
 
+  # FAILS
   asyncTest "Hole punching when peers addresses are private":
     proc connectStub(self: SwitchStub,
                     peerId: PeerId,
@@ -217,6 +220,7 @@ suite "Hole Punching":
       await self.switch.connect(peerId, addrs, forceDial, reuseConnection, upgradeDir)
     await holePunchingTest(nil, connectStub, NotReachable)
 
+  # FAILS
   asyncTest "Hole punching when there is an error during unilateral direct connection":
 
     proc connectStub(self: SwitchStub,